Skip to content

Remove $(RemoveDevicePlatformSupport) workaround #32191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

Remove $(RemoveDevicePlatformSupport) workaround #32191

merged 1 commit into from
Apr 27, 2021

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Apr 26, 2021

  • current SDK does not include Android or iOS in the @(SupportedPlatform) item group

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 26, 2021
@dougbu dougbu force-pushed the dougbu/remove.os.removals branch from 0f7f73f to 72253b6 Compare April 26, 2021 21:37
@dougbu
Copy link
Contributor Author

dougbu commented Apr 26, 2021

Note [SupportedOSPlatform] attributes are still needed in Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.dll.

@dougbu
Remove $(RemoveDevicePlatformSupport) workaround
bfa7c52 
- current SDK does not include Android or iOS in the `@(SupportedPlatform)` item group
@dougbu dougbu force-pushed the dougbu/remove.os.removals branch from 72253b6 to bfa7c52 Compare April 27, 2021 01:08
@dougbu dougbu requested a review from a team April 27, 2021 04:59
@dougbu dougbu marked this pull request as ready for review April 27, 2021 04:59
@dougbu dougbu requested review from halter73, jkotalik, Tratcher and a team as code owners April 27, 2021 04:59
SteveSandersonMS
SteveSandersonMS approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better!

@dougbu dougbu merged commit c3fe8a0 into main Apr 27, 2021
@dougbu dougbu deleted the dougbu/remove.os.removals branch April 27, 2021 23:32
@ghost ghost added this to the 6.0-preview5 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@jkotalik jkotalik jkotalik approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
6.0-preview5
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @SteveSandersonMS @jkotalik @wtgodbe