Skip to content

[release/2.1] Remove MusicStore #31812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

[release/2.1] Remove MusicStore #31812

merged 1 commit into from
May 4, 2021

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Apr 14, 2021

No description provided.

@dougbu dougbu added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates tell-mode Indicates a PR which is being merged during tell-mode labels Apr 14, 2021
@dougbu dougbu added this to the 2.1.29 milestone Apr 14, 2021
@dougbu dougbu requested a review from a team April 14, 2021 19:53
@dougbu
Copy link
Contributor Author

dougbu commented Apr 14, 2021

This isn't incredibly urgent. But, might be nice to get it into 2.1.28 if ProdCon hasn't reached this repo by the time the changes are approved and validated.

@dougbu
Copy link
Contributor Author

dougbu commented Apr 14, 2021

/fyi @mkArtakMSFT

@dougbu
Copy link
Contributor Author

dougbu commented Apr 14, 2021

/btw this is tell-mode because it only affects samples and tests.

@dougbu
Copy link
Contributor Author

dougbu commented Apr 14, 2021

@wtgodbe Any chance we can get this, #31813 and / or #31818 into the current releases❔ PRs clean up some cruft and may speed builds and tests slightly.

@dougbu
Copy link
Contributor Author

dougbu commented Apr 14, 2021

If yes, please help doing the merges as I'll be offline for a while…

@wtgodbe
Copy link
Member

wtgodbe commented Apr 14, 2021

I think #31813 is the only one we have time for, if it's green before I log off I'll merge it

@wtgodbe wtgodbe merged commit 28421b9 into release/2.1 May 4, 2021
@wtgodbe wtgodbe deleted the dougbu/thedaythemusicdied.2.1 branch May 4, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
2.1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @wtgodbe @JunTaoLuo