-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Remove Entrypoint Invoker #31769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Entrypoint Invoker #31769
Changes from all commits
f488e2b
7447451
304466a
dd72fbc
1f1dc66
7689606
c5da31d
15c84a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
**/Samples/**/.vscode/* | ||
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,7 +119,7 @@ async function boot(options?: Partial<WebAssemblyStartOptions>): Promise<void> { | |
} | ||
|
||
// Start up the application | ||
platform.callEntryPoint(resourceLoader.bootConfig.entryAssembly); | ||
await platform.callEntryPoint(resourceLoader.bootConfig.entryAssembly); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @TanayParikh @pranavkm Does this change the semantics of app startup? It depends on how I thought that, previously, calling There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be related to the functionality of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @SteveSandersonMS is correct, successfully awaiting that task should give you the exit code, control will return as soon as it can, given that the runtime is currently singly threaded. If your model expects control to yield here before the runtime has exited, don't await the entry point promise. That said, any expectations that the entry point will yield at a specific point are probably weak. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @lewing In this case, this PR is a breaking change we should fix before preview 4 ships. @TanayParikh I'll follow up separately to coordinate. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
function invokeJSFromDotNet(callInfo: Pointer, arg0: any, arg1: any, arg2: any): any { | ||
|
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.