Skip to content

Rename SlabMemoryPool #31609 #31752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2021
Merged

Rename SlabMemoryPool #31609 #31752

merged 2 commits into from
Apr 14, 2021

Conversation

careless6666
Copy link
Contributor

@careless6666 careless6666 commented Apr 13, 2021 •
edited by BrennanConroy
Loading

Renamed the SlabMemoryPool class and related objects to the suggested name PinnedBlockMemoryPool.

Fixes #31609

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 13, 2021
@dnfadmin
Copy link

dnfadmin commented Apr 13, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@ghost
Copy link

ghost commented Apr 13, 2021

Hello @BrennanConroy!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@BrennanConroy BrennanConroy added this to the 6.0-preview4 milestone Apr 13, 2021
JamesNK
JamesNK reviewed Apr 13, 2021
View reviewed changes
@ghost ghost removed the auto-merge label Apr 13, 2021
@BrennanConroy BrennanConroy merged commit 8f56489 into dotnet:main Apr 14, 2021
@BrennanConroy
Copy link
Member

Thanks @careless6666 !

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@JamesNK JamesNK JamesNK approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
6.0-preview4
Development

Successfully merging this pull request may close these issues.

Rename SlabMemoryPool
8 participants
@careless6666 @dnfadmin @BrennanConroy @halter73 @davidfowl @JamesNK @amcasey @mkArtakMSFT