-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Rebalance common headers #31495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebalance common headers #31495
Conversation
Test failure:
|
3d17322
to
8c097ac
Compare
Enumerator ordering; will change to be alpha sorted rather than listing ordered so is less fragile |
Rebased and made the ordering more deteministic so http2 header compression tests are less sensitive to where something is in the list in |
@BrennanConroy don't think its |
Yeah, I think the bot is supposed to remove that :/ |
Thanks |
Some headers in common are only used for request or response; so move them to those collections rather than having them in both.
Note: this doesn't mean they are common enough to be kept in the collections; however they definitely shouldn't be in both request and response collections.
Moved from both to only Response headers; shrinking Request headers by 72 bytes.
Contributes to #31492