Clean up WebView comments #30742
Merged
Clean up WebView comments #30742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
added
the
feature-blazor-desktop
ghost
added
the
SteveSandersonMS
commented
Mar 8, 2021
| @@ -46,8 +46,6 @@ public async Task OnMessageReceivedAsync(PageContext pageContext, string message | |||
| // For any other message, you have to have a page attached already | |||
| if (pageContext == null) | |||
| { | |||
| // TODO: Should we just ignore these messages? Is there any way their delivery | |||
| // might be delayed until after a page has detached? | |||
There was a problem hiding this comment.
I don't think there's any concern here. Nothing would go wrong unless we receives one of these messages before the first page connection, and that's impossible, because it's the page that sends them.
There was a problem hiding this comment.
Hopefully the exception here will keep us honest!
SteveSandersonMS
commented
Mar 8, 2021
| // since we only care about errors that might happen while attaching the component and the renderer doesn't | ||
| // necessarily need to know about those if we are terminating the component/host as a result. | ||
| // If we decide we need to expose the async nature of the communication channel, then we will need to keep track | ||
| // of all the message pairs/completions across the IPC channel. |
There was a problem hiding this comment.
These comments refer to an entirely different earlier incarnation of the IPC implementation.
SteveSandersonMS
commented
Mar 8, 2021
| namespace Microsoft.AspNetCore.Components.WebView | ||
| { | ||
| // These are all the messages .NET needs to know how to dispatch to JS | ||
| // TODO: Proper serialization, error handling, etc. |
There was a problem hiding this comment.
The serialization is already adequate. Error handling is something we're tightening up as part of implementing unit tests.
Eilon
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As instructed in #30656, I've reviewed the
// TODOcomments and made sure they are adequately represented in issues. I think only one of them really needs to be tracked like that; the rest are OK as-is.This PR removes the comments that are no longer applicable.