Skip to content

Avoid allocation in PathString.Add #28855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2020
Merged

Avoid allocation in PathString.Add #28855

merged 1 commit into from
Dec 28, 2020

Conversation

pranavkm
Copy link
Contributor

Also some other refactorings based on IDE's recommendations

@pranavkm
Avoid allocation in PathString.Add
ec00979 
Also some other refactorings based on IDE's recommendations

```
|    Method |     Mean |    Error |   StdDev | Ratio |
|---------- |---------:|---------:|---------:|------:|
|  Baseline | 18.56 ns | 0.099 ns | 0.088 ns |  1.00 |
|    Create | 12.70 ns | 0.174 ns | 0.154 ns |  0.68 |
```
@ghost ghost added the area-servers label Dec 25, 2020
mkArtakMSFT
mkArtakMSFT approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @pranavkm!

@pranavkm pranavkm merged commit e04dee0 into master Dec 28, 2020
@pranavkm pranavkm deleted the prkrishn/path-string branch December 28, 2020 19:51
@pranavkm pranavkm added this to the 6.0-preview1 milestone Dec 28, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavkm @Tratcher @mkArtakMSFT @amcasey