Actually fix the CopyToAsync this time #24609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hard code the 4K buffer length for CopyToAsync - Write a test this time :D
- Made tests less bad
ghost
added
the
halter73
approved these changes
Aug 6, 2020
halter73
reviewed
Aug 6, 2020
| { | ||
| public int NumberOfWrites { get; set; } | ||
|
|
||
| public override void Write(byte[] buffer, int offset, int count) |
There was a problem hiding this comment.
Maybe this should just derive from stream and write to a MemoryStream member. Then you won't have to worry about this breaking because base.Write() someday starts calling Write(ReadOnlySpan) or something like that.
Tratcher
approved these changes
Aug 6, 2020
1 task
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24032