-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update documentation on darc #24487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation on darc #24487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits and minor cleanup. I don't need to look again.
docs/ReferenceResolution.md
Outdated
|
||
Subscriptions are objects that define the ecosystem repos we are listening for updates to, the frequency we are looking for updates, and more. | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: VS Code will complain about not specifying the type of code block. This is pretty generic so bash
or ps1
would both work. If you do this, remove the leading $
s and do it for all the scripting you're adding.
docs/ReferenceResolution.md
Outdated
|
||
Note: Merge policies can only be set on unbatched subscriptions. Be sure to set/unset the `Merge Policies` field properly as you toggle batchability. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Only need one final newline 😈
Co-authored-by: Doug Bunting <[email protected]>
Hello @captainsafia! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 6 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
* Update documentation on darc * Apply suggestions from code review Co-authored-by: Doug Bunting <[email protected]> * Update code blocks in referenced assemblies Co-authored-by: Doug Bunting <[email protected]>
Add some helpful docs on how to use the
darc
command-line tool.