Skip to content

[release/5.0-preview8] Update dependencies from dotnet/arcade #23979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2020
Merged

[release/5.0-preview8] Update dependencies from dotnet/arcade #23979

merged 3 commits into from
Jul 21, 2020

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 1226e32c-1cc4-41ac-cd21-08d828bd54b7
  • Build: 20200714.3
  • Date Produced: 7/14/2020 9:08 PM
  • Commit: ff5d4b6c8dbdaeacb6e6159d3f8185118dffd915
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.GenAPI: from 5.0.0-beta.20330.3 to 5.0.0-beta.20364.3
    • Microsoft.DotNet.Helix.Sdk: from 5.0.0-beta.20330.3 to 5.0.0-beta.20364.3
    • Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20330.3 to 5.0.0-beta.20364.3

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20200…
a2a3c27 
…714.3

Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.20330.3 -> To Version 5.0.0-beta.20364.3
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner July 15, 2020 22:43
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Jul 15, 2020
ghost
ghost approved these changes Jul 15, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost ghost added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 15, 2020
@lukas-lansky
Copy link
Contributor

This problem is also present in the master and being solved: #24082

cc @mmitche @jakubstilec

@mmitche
Copy link
Member

mmitche commented Jul 21, 2020

@dougbu @lukas-lansky @ajaybhargavb. What's the status on unblockung this PR? We do need it for p8.

@dougbu
Copy link
Contributor

dougbu commented Jul 21, 2020

@ajaybhargavb and @JunTaoLuo why is the FindsTheMuxer() test still enabled❔ I thought you were going to skip it back on Friday @ajaybhargavb.

@dougbu
Update DotNetMuxerTests.cs
69aa7e5 
- skip failing test
@dougbu
Copy link
Contributor

dougbu commented Jul 21, 2020

Oh, my bad. Test is skipped in https://github.com/dotnet/aspnetcore/pull/23978/files#diff-1f095ce9abd0464f76ce01c68714ec9fR13 but not this branch.

@dougbu
Copy link
Contributor

dougbu commented Jul 21, 2020

… that is, 'til I skipped it here 😺

@mmitche mmitche merged commit 406fe1b into release/5.0-preview8 Jul 21, 2020
@mmitche mmitche deleted the darc-release/5.0-preview8-561ce4f1-4b7a-49aa-aacb-1a85a561f589 branch July 21, 2020 19:37
@mmitche
Copy link
Member

mmitche commented Jul 21, 2020

Thanks @dougbu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode Type: Dependency Update 🔼
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukas-lansky @mmitche @dougbu