Skip to content

SpaProxy: Fix proxying of WebSocket protocol #23250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2020
Merged

SpaProxy: Fix proxying of WebSocket protocol #23250

merged 2 commits into from
Jun 23, 2020

Conversation

stephtr
Copy link
Contributor

@stephtr stephtr commented Jun 23, 2020

  • Use client.Options.AddSubProtocol for setting the WebSocket protocol instead of client.Options.SetRequestHeader

Addresses #23207

@stephtr stephtr requested a review from Tratcher as a code owner June 23, 2020 07:19
@ghost ghost added the area-middleware label Jun 23, 2020
@stephtr stephtr mentioned this pull request Jun 23, 2020
Closed
@stephtr
Copy link
Contributor Author

stephtr commented Jun 23, 2020

The build failures seem to be unrelated to this PR (connection issue & file access issue).

@Tratcher
Copy link
Member

Were you able to test this locally?

@stephtr
Copy link
Contributor Author

stephtr commented Jun 23, 2020

Yes, for my Snowpack project I'm already using the modified SpaProxy. I've also successfully tested it with dotnet new react.

@Tratcher Tratcher added this to the 5.0.0-preview8 milestone Jun 23, 2020
@Tratcher Tratcher merged commit 7aa91ff into dotnet:master Jun 23, 2020
@Tratcher
Copy link
Member

Thanks

@stephtr stephtr deleted the patch-1 branch June 24, 2020 06:56
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Milestone
5.0.0-preview8
Development

Successfully merging this pull request may close these issues.
3 participants
@stephtr @Tratcher @amcasey