Consume host resolver source package from dotnet/runtime #22962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I be surprised this builds❔ I thought the package was missing a .targets file needed to include the file in compilation. |
|
The source is included without needing the .targets files. However, source link won't work without the .target file added. |
|
Got it. As long as the plan is for source link to work before RTM (preferably sooner), we're good. |
|
The work is tracked in dotnet/runtime#37921. Is there anything blocking this PR @dougbu ? |
Tratcher
reviewed
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #22843 FYI source link will be broken until discussion at dotnet/runtime#37793 is resolved.