Skip to content

Build native assets just once per job on CI #22909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2020
Merged

Build native assets just once per job on CI #22909

merged 1 commit into from
Jun 15, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Jun 13, 2020

  • at best, was a performance drain
  • at worst, broke builds entirely

@dougbu
Build native assets just once per job on CI
898d2b3 
- at best, was a performance drain
- at worst, broke builds entirely
@dougbu dougbu requested review from BrennanConroy, jkotalik and a team June 13, 2020 05:22
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 13, 2020
@dougbu dougbu merged commit 416c78b into master Jun 15, 2020
@dougbu dougbu deleted the dougbu/more.nobuildnative branch June 15, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @mmitche @wtgodbe