Skip to content

Set no-store in CookieAuthenticationHandler #22842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2020
Merged

Set no-store in CookieAuthenticationHandler #22842

merged 3 commits into from
Jun 12, 2020

Conversation

JunTaoLuo
Copy link
Contributor

Addresses #14795

@JunTaoLuo JunTaoLuo requested a review from Tratcher as a code owner June 11, 2020 20:31
@ghost ghost added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jun 11, 2020
@Tratcher
Copy link
Member

Should do the same thing here:

aspnetcore/src/Middleware/Session/src/SessionMiddleware.cs

Line 164 in 62e6d93

responseHeaders[HeaderNames.CacheControl] = "no-cache";

And do a quick search for other places we do this.

@JunTaoLuo
Copy link
Contributor Author

There looks to be quite a few places.

Tratcher
Tratcher approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, 6 components and only two tests.

@JunTaoLuo JunTaoLuo force-pushed the johluo/cookies-no-store branch from f4e5553 to e54178e Compare June 11, 2020 22:47
@JunTaoLuo JunTaoLuo merged commit ef9a366 into master Jun 12, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/cookies-no-store branch June 12, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JunTaoLuo @Tratcher