-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add nullable to DataProtection #22591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
48f17fc
to
ba16200
Compare
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
@@ -7,6 +7,8 @@ | |||
<AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
<GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
<PackageTags>aspnetcore;dataprotection</PackageTags> | |||
<Nullable>enable</Nullable> | |||
<Nullable Condition="'$(TargetFramework)' == 'netstandard2.0'">annotations</Nullable> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a seemingly random choice of enable or annotations for each csproj, and why is this the only multi-targeted one that does this logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we can only turn on nullable = annotations for ns2.0 projects. All ns2.0 APIs are oblivious, so if you rely on BCL's api for nullability, it doesn't work. In this case, we rely on annotations in Debug.Assert
. Most of the other projects here are implementation heavy, changing it is going to take a lot of work, which is they are annotation only.
src/DataProtection/EntityFrameworkCore/src/EntityFrameworkCoreXmlRepository.cs
Outdated
Show resolved
Hide resolved
ba16200
to
e1418ec
Compare
No description provided.