Skip to content

Replace favicon.ico with smaller size #22533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

Replace favicon.ico with smaller size #22533

merged 1 commit into from
Jun 10, 2020

Conversation

heyitstanyado
Copy link
Contributor

In the ProjectTemplate folder - replace favicon.icon with a smaller (5.3 KB) version.

Addresses #13491

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 4, 2020
@dnfadmin
Copy link

dnfadmin commented Jun 4, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@pranavkm
Copy link
Contributor

pranavkm commented Jun 9, 2020

@heyitstanyado thanks for the PR. Did you happen to use the icon files that @DamianEdwards listed in the issue comment?

@pranavkm pranavkm added this to the 5.0.0-preview7 milestone Jun 9, 2020
@heyitstanyado
Copy link
Contributor Author

heyitstanyado commented Jun 9, 2020 via email

pranavkm
pranavkm approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@pranavkm pranavkm merged commit e929dab into dotnet:master Jun 10, 2020
@TanayParikh TanayParikh mentioned this pull request Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
5.0.0-preview7
Development

Successfully merging this pull request may close these issues.
4 participants
@heyitstanyado @dnfadmin @pranavkm @tanyado