Skip to content

[release/2.1] Make .msi GUIDs unique #21803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 13, 2020

Customers have reported issues with our .MSI's when repairing VS. We believe the issue is due to the ProductCode/ProductVersion of the installers not being unique per build, but instead being unique per package version. Passing BuildNumber to the GUID generator should fix the issue

@wtgodbe wtgodbe requested review from Pilchie, joeloff and a team May 13, 2020 22:57
@ghost ghost added the feature-installers Includes: Installers label May 13, 2020
@wtgodbe
Copy link
Member Author

wtgodbe commented May 13, 2020

As far as I can tell, the 2.1 MSIs already have unique package versions

@@ -7,7 +7,7 @@

<PropertyGroup>
<GuidInputs>$(Version);$(Platform)</GuidInputs>
<GuidInputs Condition="'$(IsFinalBuild)' != 'true'">$(GuidInputs);$(BuildNumber)</GuidInputs>
<GuidInputs Condition="'$(IsFinalBuild)' != 'true'">$(GuidInputs);$(BuildNumber);$(BuildNumber)</GuidInputs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding $(BuildNumber) again changes nothing. Need to make use of that property unconditional.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, whoops, somehow missed it was already there. Revisiting this now

@Pilchie Pilchie added Servicing-approved Shiproom has approved the issue * NO MERGE * Do not merge this PR as long as this label is present. labels May 14, 2020
@Pilchie
Copy link
Member

Pilchie commented May 14, 2020

This was approved by Tactics, but there are no other 2.1 servicing issues at the moment, and no reason to re-ship just to pick up this fix. Next time we ship a 2.1 servicing release we should include this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-installers Includes: Installers * NO MERGE * Do not merge this PR as long as this label is present. Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants