[release/2.1] Make .msi GUIDs unique #21803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
As far as I can tell, the 2.1 MSIs already have unique package versions |
dougbu
reviewed
May 14, 2020
src/Installers/Windows/Wix.targets
Outdated
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <GuidInputs>$(Version);$(Platform)</GuidInputs> | |||
| <GuidInputs Condition="'$(IsFinalBuild)' != 'true'">$(GuidInputs);$(BuildNumber)</GuidInputs> | |||
| <GuidInputs Condition="'$(IsFinalBuild)' != 'true'">$(GuidInputs);$(BuildNumber);$(BuildNumber)</GuidInputs> | |||
There was a problem hiding this comment.
Adding $(BuildNumber) again changes nothing. Need to make use of that property unconditional.
There was a problem hiding this comment.
Ah, whoops, somehow missed it was already there. Revisiting this now
Pilchie
added
Servicing-approved
|
This was approved by Tactics, but there are no other 2.1 servicing issues at the moment, and no reason to re-ship just to pick up this fix. Next time we ship a 2.1 servicing release we should include this. |
dougbu
approved these changes
May 14, 2020
This was referenced May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers have reported issues with our .MSI's when repairing VS. We believe the issue is due to the ProductCode/ProductVersion of the installers not being unique per build, but instead being unique per package version. Passing BuildNumber to the GUID generator should fix the issue