-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Mvc] Improved route value transformer #21481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mvc] Improved route value transformer #21481
Conversation
One other alternative I thought of - we could get rid of The problem is we require the use of DI here in 3.1 - supporting both adds more choices and more to explain. |
508a17d
to
e7a6a70
Compare
See: #21471 This change just include the product-side changes and just for controllers. This addresses most the major gaps our partners have found with dynamic route value transformers. Doesn't include anything order-related.
…lidate the implementation
32778e3
to
fe7dc75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. @JamesNK could you have a look when you get a chance?
Co-authored-by: James Newton-King <[email protected]>
🆙📅 Added a check for the state not being null and matching unit tests. |
Cleaned up error messages. Thanks @JamesNK, I totally overlooked the content. Co-authored-by: James Newton-King <[email protected]>
@mkArtakMSFT Can you squash and merge this PR with the following title and comment?
|
See: #21471
This change just include the product-side changes and just for
controllers. This addresses most the major gaps our partners have found
with dynamic route value transformers. Doesn't include anything
order-related.
If we're happy with this then I can add some tests as well as make the same change for pages.