Fix AuthStateAsyncReturnsUnrelatedCancelledTask_TreatAsFailure flake #20881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
I would have @SteveSandersonMS look at this before this goes in. He's got the most context here.
src/Components/Server/test/Circuits/RevalidatingServerAuthenticationStateProvider.cs
Show resolved
Hide resolved
src/Components/Server/test/Circuits/RevalidatingServerAuthenticationStateProvider.cs
Outdated
Show resolved
Hide resolved
src/Components/Server/test/Circuits/RevalidatingServerAuthenticationStateProvider.cs
Outdated
Show resolved
Hide resolved
captainsafia
force-pushed
the
safia/head-and-shoulders
branch
from
ebe7cef to
a608981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for a flaky test that was recently quarantined.
The
AuthenticationStateChangedhandler is not guaranteed to be run by the time we reach theAssert.Equal(1, authenticationStateChangedCount);that sporadically fails in some builds.To resolve this, I used a combination of of a timeout and a new TCS to ensure that the handler was invoked before asserting. Thanks to @pranavkm for pointing me to this pattern.
Addresses #19940