Remove dependency on netstandard.library.ref

[wtgodbe]

This package isn't being produced out of dotnet/runtime anymore - we should just use the default version that is bundled with the SDK rather than listing a dependency on it.

CC @dagood @Pilchie @ericstj

[ericstj]

Can't you just remove the reference and let the SDK provide the default one?

[wtgodbe]

We probably could - looks like the only place we use the version is here:

aspnetcore/Directory.Build.targets

Lines 137 to 139 in 3787d7e

	<KnownFrameworkReference Update="NETStandard.Library">
	<TargetingPackVersion Condition="'%(TargetFramework)' == 'netstandard2.1' and '$(IsServicingBuild)' != 'true'">$(NETStandardLibraryRefPackageVersion)</TargetingPackVersion>
	</KnownFrameworkReference>

And core-sdk is already pinned to 2.1.0:

https://github.com/dotnet/core-sdk/blob/02ee648fc6ef21f615e98cf4fe0b0c7e57fb936a/eng/Version.Details.xml#L38-L40

So we should be able to get away with relying on them for the version & removing the workaround. @dougbu @JunTaoLuo do you remember if there was another reason that we needed that KnownFrameworkReference update?

[Pilchie]

Yeah, I'd prefer to remove the dependency over pinning if possible.

[wtgodbe]

Updated

[Pilchie]

LGTM assuming the KnownFrameworkReference part is ok.

[dougbu]

do you remember if there was another reason that we needed that KnownFrameworkReference update?

Believe that was added before the SDKs referenced the final .NET Standard library. Doubt we need the workaround in any branch anymore.

@ericstj dotnet/runtime is only 'master'. Do dotnet/core-setup and related repos still create / package NETStandard.Library in other branches? (@wtgodbe if not, please stand up PRs for when the other branches open using the https://github.com/dotnet/aspnetcore-internal/blob/master/docs/engineering/servicing-and-preview-fixes.md process.)

[dougbu]

assuming the KnownFrameworkReference part is ok

Yup, what @wtgodbe did is perfect.

[wtgodbe]

@dougbu I followed the instructions in https://github.com/dotnet/aspnetcore-internal/blob/master/docs/engineering/servicing-and-preview-fixes.md for this branch, is it expected there'd be merge conflicts?

[wtgodbe]

3.1 PR (same branch): #20043

[dougbu]

is it expected there'd be merge conflicts?

Yeah, I'd expect merge conflicts because you're touching eng/Versions.props -- one of the files that changes significantly between branches. Use the no-op merge approach I detailed near the bottom of https://github.com/dotnet/aspnetcore-internal/blob/master/docs/engineering/servicing-and-preview-fixes.md and restore your previous "fix for realz" changes in this branch -- separately.

[wtgodbe]

@dougbu I'm confused - I'll need to create a new branch for master, correct? I can't modify this branch without messing up #20043.

[wtgodbe]

Or is it saying I need to create a branch off of wtgodbe/standard that no-op merges #20043 to master, then separately create another PR that does the "right thing" in master off of a 3rd branch? And won't the "no-op" PR actually have some changes, since some but not all of that branch merges cleanly into master? This process seems very cumbersome...

[dougbu]

@wtgodbe see https://github.com/dotnet/aspnetcore-internal/blob/master/docs/engineering/servicing-and-preview-fixes.md#distinct-changes-needed-in-one-or-more-branch in particular. If that doesn't help unconfuse you, please contact me on Teams.

[wtgodbe]

Rebased this to be strictly against master, since the 3.1 change is unneeded