Replaced Span<T>.Fill(0) with Span<T>.Clear() #20023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoidl
requested review from
analogrelay,
halter73,
jkotalik,
SteveSandersonMS and
Tratcher
as code owners
|
Greetings human! You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo! |
ghost
added
the
| @@ -443,7 +443,7 @@ private void ClearReferences(int startIndex, int length) | |||
| // If we store references, clear them to allow the objects to be GC'd. | |||
| if (!IsValueTypeElement) | |||
| { | |||
| this.AvailableMemory.Span.Slice(startIndex, length).Fill(default); | |||
| this.AvailableMemory.Span.Slice(startIndex, length).Clear(); | |||
There was a problem hiding this comment.
The BlazorPack sources are shared-source with MessagePack-CSharp, so to update this the process would be:
- Have the desired update made in the
MessagePack-CSharprepo - Update the sources in this repo to match the latest state in
MessagePack-CSharp
There was a problem hiding this comment.
Thanks for the info --> MessagePack-CSharp/MessagePack-CSharp#848
You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime .
The bot is somewhat misleading as it speaks about "runtime"-repo. Humans are still smarter 😉
|
@anurse that bot's a bit off. |
Tratcher
approved these changes
Mar 20, 2020
halter73
approved these changes
Mar 20, 2020
This was referenced Mar 23, 2020
ColtonMori
added a commit
to ColtonMori/MessagePack
that referenced
this pull request
Oct 21, 2022
amcasey
added
area-networking
DotDeveloper95
added a commit
to DotDeveloper95/MessagePack-CSharp
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. dotnet/runtime#33813