Remove PortablePdbReader except trace cleanup

[RozzaysRed]

Summary of the changes (Less than 80 chars)

• Removes PortablePdbReader except the Dispose method so it should clean up the stack trace

Addresses #19441

[mkArtakMSFT]

Thanks for the PR, @RozzaysRed.
@pranavkm can you please look into this? Thanks!

[mkArtakMSFT]

Actually, the related issue is area-middleware so feel free to update this too, @pranavkm.

[davidfowl]

Does this affect the error page in any way?

[pranavkm]

@davidfowl likely not - we added this type because .NET Fx was unable to natively read portable pdbs. https://github.com/dotnet/aspnetcore/blob/master/src/Mvc/test/Mvc.FunctionalTests/ErrorPageTests.cs has some tests that should cover end-to-end scenarios to an extent.

[davidfowl]

@pranavkm Kewl.

@RozzaysRed can you show a screenshot of the DeveloperExceptionPage after this change?

[RozzaysRed]

@davidfowl sure as soon I figure out how to get this page, I will take the requested screenshot. I'm assuming its a dummy project and enabling that middleware? Pardon me for asking but just want to make sure I get you exactly what you are looking for.

[pranavkm]

@RozzaysRed you can run the https://github.com/dotnet/aspnetcore/blob/master/src/Mvc/samples/MvcSandbox and include screenshots for the result when an exception is thrown from

• a controller
• a Razor Page \ view

The sample is already set up to include the developer error page middleware

[RozzaysRed]

[pranavkm]

Would you mind including screenshot of an exception thrown from inside a view? We've had issues with it in the past, so it would be good to confirm that looks correct.

[pranavkm]

Looks great!

[RozzaysRed]

@pranavkm sorry about that, I thought I had pasted the file that had both. Here is the view:

[pranavkm]

Thanks!

[pranavkm]

Thanks!