Keep Kestrel's connection PipeReader in a consistent state #16725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
reviewed
Nov 1, 2019
halter73
commented
Nov 1, 2019
src/Servers/Kestrel/Core/src/Internal/Http/Http1ContentLengthMessageBody.cs
Outdated
Show resolved
Hide resolved
|
Needs @Pilchie approval to get it in, and we need to get it in today for preview3 (without QB approval). |
- When the request body PipeReader.ReadAsync throws, the connection-level pipe should be advanced, so subsequent attempts to read from the connection-level pipe don't fail unnecessarily
halter73
force-pushed
the
halter73/14727
branch
3 times, most recently
from
20ac3e0 to
1c5707e
Compare
|
This comment was made automatically. If there is a problem contact [email protected]. I've triaged the above build. I've created/commented on the following issue(s) |
|
@jkotalik this is ready. |
halter73
force-pushed
the
halter73/14727
branch
from
1c5707e to
618a66e
Compare
halter73
force-pushed
the
halter73/14727
branch
from
618a66e to
4e5acc7
Compare
jkotalik
approved these changes
Nov 4, 2019
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipe should be advanced, so subsequent attempts to read from the
connection-level pipe don't fail unnecessarily
Addresses #14727