[TS Client] Test message size #15099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wakey wakey. |
BrennanConroy
force-pushed
the
brecon/size
branch
from
ed772d2 to
d813946
Compare
|
Let's just merge this for JSON. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
halter73
reviewed
Feb 25, 2020
| registerUnhandledRejectionHandler(); | ||
|
|
||
| function createHubConnection(connection: IConnection, logger?: ILogger | null, protocol?: IHubProtocol | null) { | ||
| return HubConnection.create(connection, logger || NullLogger.instance, protocol || new JsonHubProtocol()); |
There was a problem hiding this comment.
Are the TS tests for MessagePack? It looks like these are only testing JsonHubProtocol.
There was a problem hiding this comment.
No tests for MessagePack, that's what we were talking about Friday when we decided to just get the PR in.
halter73
reviewed
Feb 25, 2020
|
|
||
| // Verify the message is sent | ||
| expect(connection.sentData.length).toBe(2); | ||
| expect((connection.sentData[1] as string).length).toEqual(29); |
There was a problem hiding this comment.
Can we verify the message type is what we expect before verifying the length?
BrennanConroy
force-pushed
the
brecon/size
branch
from
d813946 to
b147142
Compare
halter73
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as adding tests, reduced invoke, send, and stream message sizes by 15 bytes when no streaming parameters are present.