Obsolete Microsoft.AspNetCore.SpaServices and Microsoft.AspNetCore.No… #12892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanbrandenburg
requested review from
SteveSandersonMS,
danroth27 and
mkArtakMSFT
mkArtakMSFT
added
area-mvc
src/Middleware/NodeServices/samples/NodeServicesExamples/Controllers/HomeController.cs
Outdated
Show resolved
Hide resolved
src/Middleware/SpaServices.Extensions/test/SpaServicesExtensionsTests.cs
Outdated
Show resolved
Hide resolved
src/Middleware/SpaServices/src/Webpack/ConditionalProxyMiddlewareOptions.cs
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Aug 6, 2019
|
Approved by tactics |
ryanbrandenburg
force-pushed
the
rybrande/SPAServicesCleaning
branch
from
4592075 to
718904f
Compare
mkArtakMSFT
added
the
breaking-change
|
@ryanbrandenburg could you try rebasing on 3.0? We skipped a couple of the flaky tests you're seeing here. |
mkArtakMSFT
approved these changes
Aug 9, 2019
ryanbrandenburg
force-pushed
the
rybrande/SPAServicesCleaning
branch
from
613938d to
e44ed2e
Compare
|
Is there an example on how to replace calls to UseSpaPrerendering? |
eouw0o83hf
reviewed
Dec 30, 2019
| @@ -9,6 +12,7 @@ namespace Microsoft.AspNetCore.NodeServices | |||
| /// might change over time (e.g., the process might be restarted), the <see cref="INodeServices"/> instance | |||
| /// will remain constant. | |||
| /// </summary> | |||
| [Obsolete("Use Microsoft.AspNetCore.SpaServices.Extensions")] | |||
There was a problem hiding this comment.
There is no INodeServices in Microsoft.AspNetCore.SpaServices.Extensions - what are consumers supposed to be use instead?
eouw0o83hf
reviewed
Dec 30, 2019
Comment on lines
+99
to
102
| [System.ObsoleteAttribute("Use Microsoft.AspNetCore.SpaServices.Extensions")] | ||
| public static void AddNodeServices(this Microsoft.Extensions.DependencyInjection.IServiceCollection serviceCollection) { } | ||
| [System.ObsoleteAttribute("Use Microsoft.AspNetCore.SpaServices.Extensions")] | ||
| public static void AddNodeServices(this Microsoft.Extensions.DependencyInjection.IServiceCollection serviceCollection, System.Action<Microsoft.AspNetCore.NodeServices.NodeServicesOptions> setupAction) { } |
There was a problem hiding this comment.
Same question as above - there is no analog in Microsoft.AspNetCore.SpaServices.Extensions. What should be used instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11627.
Description
Pursuant to aspnet/Announcements#379 we are marking the following packages as obsolete:
Customer impact
Customers using those packages will have to switch to
Microsoft.AspNetCore.SpaServices.Extensions.Regression?
No.
Risk
Low. While it's not likely that Obsoleting a class could cause a "bug" in the traditional sense, the migration path to
Microsoft.AspNetCore.SpaServices.Extensionsis not so direct as "If you're using X method switch to Y". Instead developers will have to interact with the various CLIs directly which could lead to some confusion on their part.