Add support for increment/decrement [Parameter] usage detection. #12544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Didn't realize there was an increment or decrement operation kind. - Added tests to cover this scenario #12543
NTaylorMullen
requested review from
pranavkm,
SteveSandersonMS,
rynowak and
mkArtakMSFT
mkArtakMSFT
added
tell-mode
mkArtakMSFT
approved these changes
Jul 24, 2019
|
Go ahead! |
rynowak
reviewed
Jul 24, 2019
| else | ||
| { | ||
| var incrementOrDecrementOperation = (IIncrementOrDecrementOperation)context.Operation; | ||
| leftHandSide = incrementOrDecrementOperation.Target; |
There was a problem hiding this comment.
this is actually a great place to earn #PranavPoints by using a switch expression.
There was a problem hiding this comment.
hahah, so true. Going to leave for now so I don't have to wait for a rebuild though.
rynowak
approved these changes
Jul 24, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12543
@mkArtakMSFT can I pull this into preview8? It was something I found while validating and has very low impact. I also verified the fix in VS: