Skip to content

Move connection id creation into the transport. #11680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2019
Merged

Move connection id creation into the transport. #11680

merged 1 commit into from
Jun 28, 2019

Conversation

davidfowl
Copy link
Member

This became the obvious thing to do once I started looking at the client side of things #11672

@davidfowl
Copy link
Member Author

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=243015

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2489

@analogrelay analogrelay added this to the 3.0.0-preview7 milestone Jun 28, 2019
@analogrelay
Copy link
Contributor

Gotta land this today for p7.

@davidfowl
Copy link
Member Author

@Tratcher @halter73 @jkotalik gimme an approve

@jkotalik
Copy link
Contributor

This PR was made 4 hours ago. Give us a minute.

@analogrelay
Copy link
Contributor

analogrelay commented Jun 28, 2019 •
edited
Loading

Overhead shot of a number of people putting hands on top of each other in a "Go Team!" gesture. The final hand placed on the stack is a dog paw.

@davidfowl davidfowl merged commit 1c71752 into master Jun 28, 2019
@ghost ghost deleted the davidfowl/cid-in-transport branch June 28, 2019 17:00
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotalik jkotalik jkotalik approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging this pull request may close these issues.
5 participants
@davidfowl @aspnet-hello @analogrelay @jkotalik @amcasey