Skip to content

Move extension method out of Microsoft.AspNetCore #11148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2019
Merged

Move extension method out of Microsoft.AspNetCore #11148

merged 2 commits into from
Jun 13, 2019

Conversation

javiercn
Copy link
Member

Fixes #11022

@javiercn javiercn requested a review from davidfowl June 12, 2019 19:35
@analogrelay analogrelay added feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform area-hosting and removed feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform labels Jun 12, 2019
davidfowl
davidfowl approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@javiercn javiercn removed the request for review from analogrelay June 13, 2019 09:37
@javiercn
Copy link
Member Author

@aspnet/build The status is not getting updated in this PR and is preventing the merge.

@davidfowl
Copy link
Member

@aspnet/build The status is not getting updated in this PR and is preventing the merge.

On every single PR it seems.

@javiercn
Copy link
Member Author

I've asked @mkArtakMSFT to use the hammer.

@mkArtakMSFT
Copy link
Contributor

Merging as it seems the checks have passed, but the status isn't reflected here.

@mkArtakMSFT mkArtakMSFT merged commit 38bc43b into master Jun 13, 2019
@ghost ghost deleted the javiercn/make-fowler-happy branch June 13, 2019 15:15
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
area-hosting Includes Hosting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change namespace of StaticWebAssets extension method
6 participants
@javiercn @davidfowl @mkArtakMSFT @Tratcher @analogrelay @amcasey