Skip to content

Add a protobuf item template #10125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2019
Merged

Add a protobuf item template #10125

merged 3 commits into from
May 15, 2019

Conversation

JunTaoLuo
Copy link
Contributor

Addresses #9764.

I've verified it on the command line but I'm still figuring out how to test it in VS.

FYI, CLI help:

(AspNetCore) C:\gh\tp\Grpc> dotnet new --list
Usage: new [options]

Options:
...

Templates                                         Short Name            Language          Tags
-------------------------------------------------------------------------------------------------------------------------------
...
ASP.NET Core gRPC Service                         grpc                  [C#]              Web/gRPC
global.json file                                  globaljson                              Config
NuGet Config                                      nugetconfig                             Config
Dotnet local tool manifest file                   tool-manifest                           Config
Web Config                                        webconfig                               Config
Solution File                                     sln                                     Solution
Protocol Buffer File                              proto                                   Web/gRPC

(AspNetCore) C:\gh\tp\Grpc> dotnet new proto --help
Usage: new [options]

Options:
  -h, --help          Displays help for this command.
  -l, --list          Lists templates containing the specified name. If no name is specified, lists all templates.
  -n, --name          The name for the output being created. If no name is specified, the name of the current directory is used.
  -o, --output        Location to place the generated output.
  -i, --install       Installs a source or a template pack.
  -u, --uninstall     Uninstalls a source or a template pack.
  --nuget-source      Specifies a NuGet source to use during install.
  --type              Filters templates based on available types. Predefined values are "project", "item" or "other".
  --dry-run           Displays a summary of what would happen if the given command line were run if it would result in a template creation.
  --force             Forces content to be generated even if it would change existing files.
  -lang, --language   Filters templates based on language and specifies the language of the template to create.


Protocol Buffer File
Author: Microsoft
Description: A protocol buffer file for describing messages and services for gRPC.
    (No Parameters)

@JunTaoLuo JunTaoLuo requested review from JamesNK and shirhatti May 9, 2019 22:45
@JunTaoLuo JunTaoLuo requested a review from ryanbrandenburg as a code owner May 9, 2019 22:45
@Eilon Eilon added the area-grpc Includes: GRPC wire-up, templates label May 9, 2019
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Double check with @shirhatti on content and a template expert on implementation

@JunTaoLuo
Copy link
Contributor Author

I'm going to count @shirhatti's comment as an approval. @ryanbrandenburg any thoughts on the changes here?

@JunTaoLuo
Copy link
Contributor Author

Test failure due to https://github.com/aspnet/AspNetCore-Internal/issues/2512. Didn't rebase on the fix but it should be resolved.

@JunTaoLuo JunTaoLuo merged commit 20fcbf1 into master May 15, 2019
@JunTaoLuo JunTaoLuo deleted the johluo/proto-item-template branch May 15, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants