Unit testing HttpContext with HTTP2 features

[JamesNK]

Is there a simple way to create a HttpContext with HTTP2 features? I want to write some HTTP2-ish unit tests.

var context = new DefaultHttpContext();
context.Response.AppendTrailers("", "");

This throws an error because there is no IHttpResponseTrailersFeature.

Is there a simple way to make the context HTTP2-erized. If not, consider adding one.

[JamesNK]

Http2Stream implements the interface, but it has its own context argument, and passing in the context without setting properties throws a null reference exception. This is the point I gave up.

I'm going to mock a IHttpResponseTrailersFeature for now.

[davidfowl]

cc @Tratcher

[Tratcher]

Yeah, making and setting your own IHttpResponseTrailersFeature ought to be trivial. There's also a IHeadersDictionary implementation in Http you can re-use.

This isn't a feature that DefaultHttpContext should provide by default, you need to know it's going to work before calling it. We could make a dummy implementation of the feature though so you just have to new it up and set it.

[analogrelay]

Duplicate of #6880 ?

[JamesNK]

This issue is about using DefaultHttpContext with trailers independently.

#6880 is about using trailers inside TestHost.

[analogrelay]

Since trailers aren't as reliable a feature, I don't think we'd put this in DefaultHttpContext directly, we could have a one-liner to initialize the trailers feature though.

[analogrelay]

We'll leave this in preview 7, but it's on the verge :). If you're passionate @JamesNK , we take PRs 🐴