Skip to content

Pool HTTP/2 Streams on the Http2Connection #6192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidfowl opened this issue Dec 30, 2018 · 4 comments · Fixed by #18601
Closed

Pool HTTP/2 Streams on the Http2Connection #6192

davidfowl opened this issue Dec 30, 2018 · 4 comments · Fixed by #18601
Assignees
@jkotalik
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel HTTP2 Perf
Milestone
5.0.0-preview1

Comments

@davidfowl
Copy link
Member

davidfowl commented Dec 30, 2018 •
edited by analogrelay
Loading

Epic #8858

Today we have a maximum number streams per HTTP/2 connection and we could take advantage of that to pool and reuse the underlying HTTP/2 stream instead of making a new one every request. This should be a massive saving in allocations and will trend towards our HTTP/1 allocation profile.

POC: https://github.com/aspnet/AspNetCore/pull/6130/files
@davidfowl davidfowl added this to the 3.0.0 milestone Dec 30, 2018
@davidfowl davidfowl self-assigned this Dec 30, 2018
@davidfowl davidfowl mentioned this issue Jan 6, 2019
Merged
@davidfowl davidfowl modified the milestones: 3.0.0, 3.0.0-preview3 Jan 23, 2019
@davidfowl
Copy link
Member Author

Moving to preview4

@davidfowl davidfowl mentioned this issue Feb 16, 2019
Closed
@analogrelay
Copy link
Contributor

@Eilon checked in with @davidfowl on this and he said it should probably be reassigned to someone who's working on gRPC since it will be part of that.

@analogrelay analogrelay mentioned this issue Mar 27, 2019
Closed
1 task
@Eilon Eilon added area-grpc Includes: GRPC wire-up, templates and removed area-servers labels Mar 27, 2019
@Eilon
Copy link
Contributor

Eilon commented Mar 27, 2019

Okie dokie, moving to gRPC area.

@JamesNK JamesNK modified the milestones: 3.0.0-preview4, 3.0.0-preview5 Apr 1, 2019
@JamesNK
Copy link
Member

JamesNK commented Apr 1, 2019

gRPC team does not have time to do this in preview 4. Moving to 5.

@Eilon Eilon modified the milestones: 3.0.0-preview5, 3.0.0-preview6 Apr 19, 2019
@JamesNK JamesNK modified the milestones: 3.0.0-preview6, 3.0.0-preview7 May 7, 2019
@analogrelay analogrelay added area-servers and removed area-grpc Includes: GRPC wire-up, templates labels Jul 10, 2019
@analogrelay analogrelay modified the milestones: 3.0.0-preview9, Backlog Jul 30, 2019
@JamesNK JamesNK added the HTTP2 label Aug 23, 2019
@shirhatti shirhatti modified the milestones: Backlog, 5.0.0-preview1 Sep 5, 2019
@JamesNK JamesNK mentioned this issue Sep 5, 2019
Closed
7 tasks
@jkotalik jkotalik self-assigned this Jan 27, 2020
@jkotalik jkotalik mentioned this issue Jan 27, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jkotalik jkotalik

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel HTTP2 Perf
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging a pull request may close this issue.

Start pooling Http2Streams dotnet/aspnetcore
8 participants
@analogrelay @davidfowl @Eilon @JamesNK @JunTaoLuo @shirhatti @jkotalik @amcasey