Skip to content

Non-Pascal property casing in SampleQuickGridComponent Person record? #60325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
guardrex opened this issue Feb 12, 2025 · 4 comments · Fixed by #60340
Closed
1 task done

Non-Pascal property casing in SampleQuickGridComponent Person record? #60325

guardrex opened this issue Feb 12, 2025 · 4 comments · Fixed by #60340
Labels
area-blazor Includes: Blazor, Razor Components help wanted Up for grabs. We would accept a PR to help resolve this issue
Milestone

Comments

@guardrex
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

While working on documentation for RowClass (.NET 10), I noticed record primary ctor params/props of the SampleQuickGridComponent component without Pascal casing (firstName, lastName) ...

record Person(int PersonId, string firstName, string lastName, DateOnly BirthDate);

Cross-ref: https://github.com/dotnet/aspnetcore/pull/59901/files

Expected Behavior

Pascal casing? ...

record Person(int PersonId, string FirstName, string LastName, DateOnly BirthDate);

... and then further updates in the component to mirror that change.

Steps To Reproduce

No response

Exceptions (if any)

None

.NET Version

No response

Anything else?

None

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Feb 12, 2025
@javiercn javiercn added this to the Backlog milestone Feb 12, 2025
@javiercn javiercn added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Feb 12, 2025
Copy link
Contributor

Looks like this issue has been identified as a candidate for community contribution. If you're considering sending a PR for this issue, look for the Summary Comment link in the issue description. That comment has been left by an engineer on our team to help you get started with handling this issue. You can learn more about our Help Wanted process here

@javiercn
Copy link
Member

@guardrex Is this test code?

I don't think we care much about this, but if someone wants to send a PR we will take it.

@guardrex
Copy link
Contributor Author

guardrex commented Feb 12, 2025

Yep! Just a passing notice on it. If you don't care, this issue can be closed.

The doc example uses Pascal case ...

https://learn.microsoft.com/en-us/aspnet/core/blazor/components/quickgrid?view=aspnetcore-10.0&tabs=visual-studio#style-a-table-row-based-on-the-row-item

@shethaadit
Copy link
Contributor

Hi @javiercn, I have submitted PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants