[8.0] RouteHandlerAnalyzer throws InvalidOperationException

[adamsitnik]

I've hit the following error while working on Xabaril/AspNetCore.Diagnostics.HealthChecks#2044.

CSC : error AD0001: Analyzer 'Microsoft.AspNetCore.Analyzers.RouteHandlers.RouteHandlerAnalyzer' threw an exception of type 'System.InvalidOperationException' with message 'Failed to resolve well-known type 'Microsoft.AspNetCore.Builde
r.EndpointRouteBuilderExtensions'.'. 

PS D:\projects\forks\healthChecks> dotnet --info
.NET SDK:
 Version:   8.0.100-rc.2.23429.6
 Commit:    4bafa2271a

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.22621
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\8.0.100-rc.2.23429.6\

Repro:

git clone https://github.com/adamsitnik/AspNetCore.Diagnostics.HealthChecks.git --branch reproBug reproBug
cd reproBug
dotnet build .\test\HealthChecks.UI.Tests\HealthChecks.UI.Tests.csproj

[captainsafia]

Thanks for reporting this issue, @adamsitnik! We've gotten a few similar reports over the past few days including in #50868 and #50881. I'll close those in favor of using this one as the investigation.

#50868 highlights the framework reference being included as possibly related but I think that there might be a red herring considering the nature of the other bug reports. I'll dig in and see what I can find...I suspect upgrading runtime versions ithe more likely dilemma here...

[captainsafia]

OK, it turns out that this is related to the fact that the HealthChecks UI package uses the same type name in their sources as we do in ours:

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/4607fc5b338388d3fcf302fc60fb004961825b9a/src/HealthChecks.UI/Extensions/EndpointRouteBuilderExtensions.cs#L9

Since we use GetTypeByMetadataName, it will return null if types by the same name are encountered in different assemblies. We can be more defensive here and use GetTypesByMetadataName then filter to the assemblies that we care about.

[glen-84]

This is also affecting HotChocolate.