Skip to content

[QuickGrid] ColumnBase align check uses incorrect logical operator. #47857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
Drake53 opened this issue Apr 24, 2023 · 3 comments
Closed
1 task done

[QuickGrid] ColumnBase align check uses incorrect logical operator. #47857

Drake53 opened this issue Apr 24, 2023 · 3 comments
Assignees
@mkArtakMSFT
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. feature-blazor-quickgrid
Milestone
8.0-preview5

Comments

@Drake53
Copy link

Drake53 commented Apr 24, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

In https://github.com/dotnet/aspnetcore/blob/main/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/Columns/ColumnBase.razor

The following line
@if (ColumnOptions is not null && (Align != Align.Right || Align != Align.End))
should be:
@if (ColumnOptions is not null && (Align != Align.Right && Align != Align.End))

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response
@ghost ghost added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Apr 24, 2023
@adityamandaleeka adityamandaleeka added area-blazor Includes: Blazor, Razor Components feature-blazor-quickgrid and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Apr 24, 2023
@adityamandaleeka
Copy link
Member

Good catch @Drake53. Are you interested in contributing a fix?

@Drake53
Copy link
Author

Drake53 commented Apr 24, 2023

I'd have to fork & clone the entire aspnetcore repo in order to create a PR, seems like a lot of effort for such a small fix so I'd appreciate it if someone else could create a PR for this.

@adityamandaleeka
Copy link
Member

@Drake53 No worries at all! Just wanted to check before someone else did it in case you were hoping to 😄

mkArtakMSFT added a commit that referenced this issue Apr 25, 2023
@mkArtakMSFT
Fixing #47857
4f671ff
@mkArtakMSFT mkArtakMSFT self-assigned this Apr 25, 2023
@mkArtakMSFT mkArtakMSFT mentioned this issue Apr 26, 2023
Merged
mkArtakMSFT added a commit that referenced this issue Apr 26, 2023
@mkArtakMSFT
Fixing #47857 (#47886)
509ba52
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Apr 26, 2023
@mkArtakMSFT mkArtakMSFT added this to the 8.0-preview5 milestone Apr 26, 2023
dotnet-bot pushed a commit to dotnet/dotnet that referenced this issue May 3, 2023
@dotnet-maestro
[aspnetcore] Sync 015ceab → 42d14c4
45bd677 
Diff: https://github.com/dotnet/aspnetcore/compare/015ceab6aeec700fbfb71cdfe9ff8fb51831d555..42d14c4bab2afb8cddc1f9683aa8ff2e20a46edb

From: dotnet/aspnetcore@015ceab
To: dotnet/aspnetcore@42d14c4

Commits:
  - Update dependencies from https://github.com/dotnet/runtime build 20230426.2 (#47904)
    dotnet/aspnetcore@cc54ac3
  - Replace ISystemClock in SignalR (#47895)
    dotnet/aspnetcore@69e3a5d
  - Fixed Router renders component twice (#47880)
    dotnet/aspnetcore@b07544b
  - Fixing dotnet/aspnetcore#47857 (#47886)
    dotnet/aspnetcore@509ba52
  - Add suppression message to JSON serialization (#47908)
    dotnet/aspnetcore@e821f20
  - RDG metadata generation based on endpoint response type. (#47741)
    dotnet/aspnetcore@fb278a6
  - [GenerateEmbeddedResourcesManifest] handle Items with empty LogicalName #29306 (#47887)
    dotnet/aspnetcore@2dbc828
  - Fixes CI build failures after conflicting merge affecting RDG baselines. (#47917)
    dotnet/aspnetcore@58940e3
  - Quarantine BlazorWasmHostedTemplate_IndividualAuth_NoHttps_Works_WithOutLocalDB (#47920)
    dotnet/aspnetcore@d9b3951
  - Update dependencies from https://github.com/dotnet/runtime build 20230427.1 (#47921)
    dotnet/aspnetcore@b0917f4
  - Fix F# starter web template. (#47697)
    dotnet/aspnetcore@0db29cc
  - Add MapIdentityApi<TUser>() (#47414)
    dotnet/aspnetcore@d4430f0
  - Enable prebuilt detection (#47894)
    dotnet/aspnetcore@6d30638
  - Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2168950 (#47784)
    dotnet/aspnetcore@c3b9515
  - Add comment about SourceBuildPrebuilt versions (#47935)
    dotnet/aspnetcore@e233a32
  - Update SDK to 8.0.100-preview.5.23226.2 (#47540)
    dotnet/aspnetcore@1b78513
  - Remove unused variable (#47931)
    dotnet/aspnetcore@ab1bfa7
  - Enable AOT template tests (#47247)
    dotnet/aspnetcore@c6ccf23
  - Update dependencies from https://github.com/dotnet/runtime build 20230428.1 (#47956)
    dotnet/aspnetcore@64e4c50
  - Remove support for name attribute when hash routing (#47954)
    dotnet/aspnetcore@1e39822
  [... commit list trimmed ...]

[[ commit created by automation ]]
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mkArtakMSFT mkArtakMSFT

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. feature-blazor-quickgrid
Projects
None yet
Milestone
8.0-preview5
Development

No branches or pull requests
3 participants
@adityamandaleeka @mkArtakMSFT @Drake53