Skip to content

Quarantine ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug #41850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TanayParikh opened this issue May 25, 2022 · 4 comments
Closed
Assignees
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure test-fixed
Milestone

Comments

@TanayParikh
Copy link
Contributor

Failing Test(s)

  • Microsoft.AspNetCore.Server.Kestrel.Sockets.FunctionalTests.ResponseTests.ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug

Error Message

System.AggregateException : One or more hosted services failed to stop. (An error occurred while writing to logger(s). (Shutdown failure. Log Debug[NotAllConnectionsClosedGracefully]: Some connections failed to close gracefully during server shutdown. ))
---- System.AggregateException : An error occurred while writing to logger(s). (Shutdown failure. Log Debug[NotAllConnectionsClosedGracefully]: Some connections failed to close gracefully during server shutdown. )
-------- System.Exception : Shutdown failure. Log Debug[NotAllConnectionsClosedGracefully]: Some connections failed to close gracefully during server shutdown.



Stacktrace

   at Microsoft.Extensions.Hosting.Internal.Host.StopAsync(CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.TestServer.DisposeAsync() in /_/src/Servers/Kestrel/shared/test/TransportTestHelpers/TestServer.cs:line 148
   at Microsoft.AspNetCore.Server.Kestrel.Sockets.FunctionalTests.ResponseTests.ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug(ListenOptions listenOptions) in /_/src/Servers/Kestrel/test/FunctionalTests/ResponseTests.cs:line 430
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
   at Microsoft.Extensions.Logging.Logger.ThrowLoggingError(List`1 exceptions)
   at Microsoft.Extensions.Logging.Logger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
   at Microsoft.Extensions.Logging.LoggerMessage.<>c__DisplayClass8_0.<Define>g__Log|0(ILogger logger, Exception exception)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.KestrelTrace.ConnectionsLog.NotAllConnectionsClosedGracefully(ILogger logger) in /_/src/Servers/Kestrel/Core/src/Microsoft.Extensions.Logging.Generators/Microsoft.Extensions.Logging.Generators.LoggerMessageGenerator/LoggerMessage.g.cs:line 157
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.<>c__DisplayClass14_0.<<StopTransportsAsync>g__StopTransportConnection|0>d.MoveNext() in /_/src/Servers/Kestrel/Core/src/Internal/Infrastructure/TransportManager.cs:line 110
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.StopTransportsAsync(List`1 transportsToStop, CancellationToken cancellationToken) in /_/src/Servers/Kestrel/Core/src/Internal/Infrastructure/TransportManager.cs:line 130
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StopAsync(CancellationToken cancellationToken) in /_/src/Servers/Kestrel/Core/src/Internal/KestrelServerImpl.cs:line 281
   at Microsoft.AspNetCore.Hosting.GenericWebHostService.StopAsync(CancellationToken cancellationToken) in /_/src/Hosting/Hosting/src/GenericHost/GenericWebHostService.cs:line 175
   at Microsoft.Extensions.Hosting.Internal.Host.StopAsync(CancellationToken cancellationToken)
----- Inner Stack Trace -----
   at Microsoft.AspNetCore.Testing.TestApplicationErrorLogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter) in /_/src/Servers/Kestrel/shared/test/TestApplicationErrorLogger.cs:line 86
   at Microsoft.Extensions.Logging.Logger.<Log>g__LoggerLog|13_0[TState](LogLevel logLevel, EventId eventId, ILogger logger, Exception exception, Func`3 formatter, List`1& exceptions, TState& state)

Logs

ResponseTests_ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug-http_127.0.0.1_0.log
ResponseTests_ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug-http_127.0.0.1_0.0.log

Build

https://dev.azure.com/dnceng/public/_build/results?buildId=1789306&view=ms.vss-test-web.build-test-results-tab&runId=47864982&resultId=120859&paneView=debug

@adityamandaleeka
Copy link
Member

Looks like this happened on another run a week ago with the same issue (also macOS). This is similar to other flakiness we've seen on socket tests on macOS. Let's add retries to this one.

@HaoK
Copy link
Member

HaoK commented Jul 27, 2022

Added to retry in #42935

@HaoK HaoK closed this as completed Jul 27, 2022
@HaoK HaoK reopened this Jul 27, 2022
@HaoK
Copy link
Member

HaoK commented Jul 27, 2022

Oops need to keep this open to track unquarantining after 30 days in retry

@HaoK
Copy link
Member

HaoK commented Sep 3, 2022

Fixed by #43717

@HaoK HaoK closed this as completed Sep 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure test-fixed
Projects
None yet
Development

No branches or pull requests

4 participants