Skip to content

Expose InMemoryTransportFactory as a public API #40893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
arontsang opened this issue Mar 26, 2022 · 6 comments
Open
1 task done

Expose InMemoryTransportFactory as a public API #40893

arontsang opened this issue Mar 26, 2022 · 6 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone

Comments

@arontsang
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Unit Testing AspNetCore, run unit tests without creating a socket. Which would likely make it harder to run concurrent tests on a CI server.

Describe the solution you'd like

Being able to run AspNetCore Kestrel completely in memory.

Additional context

No response

@davidfowl
Copy link
Member

You can unit test ASP.NET Core without the in memory transport being public. Do you have an example of what you want to test?

@arontsang
Copy link
Author

arontsang commented Mar 26, 2022 via email

@davidfowl
Copy link
Member

Perfect, that was the missing data here. Thanks for the clarification.

@halter73
Copy link
Member

We've talked about using Kestrel to implement TestServer before to make certain behaviors and features more consistent between tests and real applications. #11598

We could do this and provide a way to access the raw client IDuplexPipe.

@adityamandaleeka
Copy link
Member

Triage: this seems like something that would have very limited use cases, so it's hard to justify the effort of designing and providing the real API surface for this.

Moving to backlog. If there's an increase in demand we may consider it in the future.

@adityamandaleeka adityamandaleeka added this to the Backlog milestone Mar 30, 2022
@ghost
Copy link

ghost commented Mar 30, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

No branches or pull requests

6 participants