RoleExistsAsync method not working in Identity RoleManager

[faresamr]

Describe the bug

roleManager.RoleExistsAsync("myRole") always returns null value as if the role doesn't exist even if its there.

🙌 I will be glad to contribute a fix for it and check if there is any other methods do the same thing

This happens because of role name gets normalized twice, first RoleExistsAsync normalize the parameter value then pass it to FindByNameAsync where it gets normalized for the second time which leads to a normalized value doesn't exists

aspnetcore/src/Identity/Extensions.Core/src/RoleManager.cs

Lines 229 to 238 in ad5cc24

	public virtual async Task<bool> RoleExistsAsync(string roleName)
	{
	ThrowIfDisposed();
	if (roleName == null)
	{
	throw new ArgumentNullException(nameof(roleName));
	}
	return await FindByNameAsync(NormalizeKey(roleName)) != null;
	}

aspnetcore/src/Identity/Extensions.Core/src/RoleManager.cs

Lines 318 to 327 in ad5cc24

	public virtual Task<TRole> FindByNameAsync(string roleName)
	{
	ThrowIfDisposed();
	if (roleName == null)
	{
	throw new ArgumentNullException(nameof(roleName));
	}
	return Store.FindByNameAsync(NormalizeKey(roleName), CancellationToken);
	}

This case was not covered by unit test because of UpperInvariantLookupNormalizer is being used as normalizer which dose not make any deference if the value gets normalized more than once, but my case I'm using hashing

To Reproduce

await roleManager.CreateAsync(new IdentityRole("myRole"));
IdentityRole role = await roleManager.RoleExistsAsync("myRole");
//role is null

Exceptions (if any)

No Exceptions.

Further technical details

• ASP.NET Core 5.0

[HaoK]

Yeah this seems like a legit bug, @faresamr do you want to submit a PR? We'd take this for 6.0-rc2 I think

[HaoK]

Feel free to update the unit tests to use a mutating normalizer to flush out this issue more generally

[faresamr]

Yes I can fix it and I will submit a PR today, how can I get access to submit PR?

[HaoK]

https://guides.github.com/activities/forking/