Add a Redirect overload that takes PathString, QueryString, etc..

[Tratcher]

https://github.com/aspnet/Mvc/issues/8518

The redirect overloads that take a string do not do the encoding for you. Consider adding an overload that accepted the component parts and assembled and encoded them for you. This would likely delegate to the UriHelper.BuildRelative and BuildAbsolute APIs.

[davidfowl]

@Tratcher can you propose an API here?

[Tratcher]

Here's what we have today:

aspnetcore/src/Http/Http.Abstractions/src/HttpResponse.cs

Lines 133 to 141 in 27ff2f4

	public virtual void Redirect(string location) => Redirect(location, permanent: false);
	/// <summary>
	/// Returns a redirect response (HTTP 301 or HTTP 302) to the client.
	/// </summary>
	/// <param name="location">The URL to redirect the client to. This must be properly encoded for use in http headers
	/// where only ASCII characters are allowed.</param>
	/// <param name="permanent"><c>True</c> if the redirect is permanent (301), otherwise <c>false</c> (302).</param>
	public abstract void Redirect(string location, bool permanent);

These are the helpers we want to make more discoverable:

aspnetcore/src/Http/Http.Extensions/src/UriHelper.cs

Lines 30 to 34 in 27ff2f4

	public static string BuildRelative(
	PathString pathBase = new PathString(),
	PathString path = new PathString(),
	QueryString query = new QueryString(),
	FragmentString fragment = new FragmentString())

aspnetcore/src/Http/Http.Extensions/src/UriHelper.cs

Lines 51 to 57 in 27ff2f4

	public static string BuildAbsolute(
	string scheme,
	HostString host,
	PathString pathBase = new PathString(),
	PathString path = new PathString(),
	QueryString query = new QueryString(),
	FragmentString fragment = new FragmentString())

I'd suggest extensions as follows. I've given overloads with and without PathBase as that's a less common feature.

public static void Redirect(this HttpResponse response,
            PathString path,
            QueryString query = new QueryString(),
            FragmentString fragment = new FragmentString(),
            bool permenant = false);

public static void Redirect(this HttpResponse response,
            PathString pathBase,
            PathString path,
            QueryString query = new QueryString(),
            FragmentString fragment = new FragmentString(),
            bool permenant = false);

public static void Redirect(this HttpResponse response,
            string scheme,
            HostString host,
            PathString path = new PathString(),
            QueryString query = new QueryString(),
            FragmentString fragment = new FragmentString(),
            bool permenant = false);

public static void Redirect(this HttpResponse response,
            string scheme,
            HostString host,
            PathString pathBase = new PathString(),
            PathString path = new PathString(),
            QueryString query = new QueryString(),
            FragmentString fragment = new FragmentString(),
            bool permenant = false);

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.