Skip to content

Make StartupAnalysisBuilder-based analyzers work with WebApplicationBuilder #34404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #35528
halter73 opened this issue Jul 16, 2021 · 1 comment · Fixed by #35747
Closed
Tracked by #35528

Make StartupAnalysisBuilder-based analyzers work with WebApplicationBuilder #34404

halter73 opened this issue Jul 16, 2021 · 1 comment · Fixed by #35747
Assignees
@BrennanConroy
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-hosting Priority:2 Work that is important, but not critical for the release
Milestone
6.0-rc2

Comments

@halter73
Copy link
Member

Today we have analyzers that warn for various misconfigurations of middleware, options and service registration all based on StartupAnalysisBuilder. We should make this work for applications using WebApplicationBuilder without a Startup class.

This is related to #34146. We want to address that with a new analyzer to verify middleware ordering for WebApplicationBuilder now that UseRouting()/UseEndpoints() is often implicit.
@rafikiassumani-msft rafikiassumani-msft added this to the 6.0-rc1 milestone Jul 19, 2021
@rafikiassumani-msft rafikiassumani-msft modified the milestones: 6.0-rc1, 6.0-rc2 Jul 19, 2021
@rafikiassumani-msft rafikiassumani-msft added the Priority:2 Work that is important, but not critical for the release label Jul 20, 2021
@JunTaoLuo JunTaoLuo removed their assignment Aug 2, 2021
@JunTaoLuo
Copy link
Contributor

This should probably be re-assigned.

@mkArtakMSFT mkArtakMSFT mentioned this issue Aug 12, 2021
Closed
@captainsafia captainsafia mentioned this issue Aug 23, 2021
Closed
4 tasks
@BrennanConroy BrennanConroy mentioned this issue Aug 26, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2021
@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrennanConroy BrennanConroy

Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-hosting Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
6.0-rc2
Development

Successfully merging a pull request may close this issue.

Startup analyzers work for minimal apps dotnet/aspnetcore
6 participants
@halter73 @Pilchie @JunTaoLuo @BrennanConroy @amcasey @rafikiassumani-msft