Skip to content

Update StartupAnalyzer to account for top level statements #34042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pranavkm opened this issue Jul 2, 2021 · 4 comments
Closed

Update StartupAnalyzer to account for top level statements #34042

pranavkm opened this issue Jul 2, 2021 · 4 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Duplicate Resolved as a duplicate of another issue help wanted Up for grabs. We would accept a PR to help resolve this issue Status: Resolved
Milestone

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Jul 2, 2021

The StartupAnalyzer specifically looks for types named Startup and will not apply to the minimal hosting pattern.

@pranavkm
Copy link
Contributor Author

pranavkm commented Jul 2, 2021

FYI @DamianEdwards

@pranavkm pranavkm added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 2, 2021
@davidfowl davidfowl added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Jul 3, 2021
@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Jul 9, 2021
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Jul 9, 2021
@ghost
Copy link

ghost commented Jul 9, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@singh733
Copy link
Contributor

@pranavkm I have started working on this .When there is only top level statement no breakpoint hits .I have put breakpoint in these projects (in kestrel, TransportSockets, Hosting) . Would you please give more detail like : which file or project i need to look.

Top Level Startup

@mkArtakMSFT
Copy link
Contributor

This is a dupe of #34404

@mkArtakMSFT mkArtakMSFT added the ✔️ Resolution: Duplicate Resolved as a duplicate of another issue label Aug 12, 2021
@ghost ghost added the Status: Resolved label Aug 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Duplicate Resolved as a duplicate of another issue help wanted Up for grabs. We would accept a PR to help resolve this issue Status: Resolved
Projects
None yet
Development

No branches or pull requests

4 participants