Skip to content

Large number of duplicate strings for concurrent websocket connections #31305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidfowl opened this issue Mar 27, 2021 · 2 comments · Fixed by #31311
Closed

Large number of duplicate strings for concurrent websocket connections #31305

davidfowl opened this issue Mar 27, 2021 · 2 comments · Fixed by #31311
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel Perf
Milestone

Comments

@davidfowl
Copy link
Member

davidfowl commented Mar 27, 2021

Seems like something we could consider interning:

image

We could probably eliminate this by making these known headers (though I think we should potentially remove other known headers and replace them with the websocket headers 😄).

cc @benaadams

@benaadams
Copy link
Member

Should resolve it? #31311

It won't get rid of localhost:5000 though as the Host value; that is amortized across many requests and the WebSocket upgrade is just one per connection. Would need a different approach.

Could switch it in the "allowed origins" middleware; so if you specify allowed origins and one matches then it could switch the header value for the string object in the middleware options? 🤔

@BrennanConroy BrennanConroy added this to the Next sprint planning milestone Mar 29, 2021
@ghost
Copy link

ghost commented Mar 29, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost ghost closed this as completed in #31311 Mar 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel Perf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants