Skip to content

Remove connection-specific headers for HTTP/2 and HTTP/3 #24502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kahbazi opened this issue Aug 1, 2020 · 3 comments · Fixed by #24543
Closed

Remove connection-specific headers for HTTP/2 and HTTP/3 #24502

Kahbazi opened this issue Aug 1, 2020 · 3 comments · Fixed by #24543
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel
Milestone

Comments

@Kahbazi
Copy link
Member

Kahbazi commented Aug 1, 2020

Spec for HTTP/2 and HTTP/3 states that connection-specific headers should be removed.

Such intermediaries SHOULD also remove other connection-specific fields, such as Keep-Alive, Proxy-Connection, Transfer-Encoding, and Upgrade, even if they are not nominated by the Connection field.

I want to create a PR for this issue. Is there any special way to add methods for clearing headers in HttpHeaders.Generated.cs since it's generated?
https://github.com/dotnet/aspnetcore/pull/24315/files/fb66a4e496ba49e3976731ad91be84fbafc9c936#diff-af588a349fd0f3044d4e05739c9c4293R8010-R8015

/cc @Tratcher

@Tratcher
Copy link
Member

Tratcher commented Aug 1, 2020

The source for that generated file is called KnownHeaders. You edit it like this:
https://github.com/dotnet/aspnetcore/pull/24315/files/fb66a4e496ba49e3976731ad91be84fbafc9c936#diff-9d6067e45fb1196b82da0a0e7c96040e
Then you run the CodeGenerator project. I usually just CTL+F5 to run it in VS, but you should be able to dotnet run it as well.
https://github.com/Kahbazi/AspNetCore/tree/fb66a4e496ba49e3976731ad91be84fbafc9c936/src/Servers/Kestrel/tools/CodeGenerator

@ghost
Copy link

ghost commented Aug 3, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Aug 31, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@ghost ghost closed this as completed in #24543 Nov 25, 2020
@Tratcher Tratcher modified the milestones: Backlog, 6.0-preview1 Nov 25, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants