Asp.net core putting the same Guid for all empty Guid's

[jrrcdev]

Hello, guys.

I'm going through a problem when using Guid as Id, when I have Entity like:

`
public class SubcategoryDto
{
public Guid Id { get; set; }

    public string Description { get; set; }

    public Guid CategoryId { get; set; }
}`

and I have a Action in my controller with:

public IActionResult Create(Guid id) { var dto = new SubcategoryDto() { CategoryId = id }; return View(dto); }

I expect in my View I receive the follow object:

{
"id": "00000000-0000-0000-0000-000000000000",
"description": "",
"categoryid": "dba6b8e4-fb16-4f88-290d-08d44abea368"
}

But I receive:

{
"id": "dba6b8e4-fb16-4f88-290d-08d44abea368",
"description": "",
"categoryid": "dba6b8e4-fb16-4f88-290d-08d44abea368"
}

So, is it a issue or I need to do some configuration?

[Tratcher]

@rynowak ?

[rynowak]

We don't have any magic around guids. I don't see anything in the code sample that sets the Id value thus it should always be empty.

Do you have a more complete code sample including the view, and ideally what the request looks like?

[jrrcdev]

Here is a test repo:
https://github.com/jonatanrinckus/AspNetCoreGuidIssueTest

the HomeController has this action:

public IActionResult Edit(Guid id) { var test = new Test() { AnotherGuidId = id }; return View(test); }
if you go to /home/edit/4689d77b-a373-450d-a7e6-3394b557ce32
It you bring the Guid on both inputs, but this should me just on one.

And it just happens if the name of parameter is "id".

if I add a [Route("{id}"] attribute, the same happens.

If i change for another parameter name like "idt" and [Route("{idt}"], it works like expected.

[rynowak]

This happens because entries in the ModelState take precedence over the values in the model. This is needed because when you submit a form and are sent back to the form (because of validation errors) you want to see the inputs that you typed in, and not the values on the model.

/cc @dougbu in case he wants to add more

When you successfully bind the id route value, it creates an entry in the ModelState for that value. If you don't want to see that on the form, just clear it.

        public IActionResult Edit(Guid id)
        {
            var test = new Test()
            {
                AnotherGuidId = id
            };

            ModelState.Remove("id");

            return View(test);
        }

[aspnet-hello]

This issue is being closed because it has not been updated in 3 months.

We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.

[davidalpert]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: spinthemoose@gmail.com Domain spinthemoose.com has exceeded the max emails per hour (216/200 (108%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from github-smtp2-ext4.iad.github.net ([192.30.252.195]:48958 helo=github-smtp2a-ext-cp1-prd.iad.github.net) by cp1164.blacksun.ca with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from <noreply@github.com>) id 1eVQfy-0000GU-EH for david@spinthemoose.com; Sat, 30 Dec 2017 17:36:26 -0600 Date: Sat, 30 Dec 2017 15:36:06 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1514676966; bh=uHhsz/F6s96V/iYVoAoWSyYq9MRA11ukl6m7uZa0+Nw=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jYLzRFIgaqHsAePxrhmtoZyXgBFnu5uzCAUvSNxaIMXo6N2dsSMVVYzKIc9mC8oXl I7GhV5+nutpaSwmTHNfSg2dxSixxudMwPa5iaqtyqvrP8pNols4RoTb905G9/FBslJ qC2xkbzpvn2q/R/uEKv427Q5/RLQN5E+h74D8gak= From: "ASP.NET Hello Bot" <notifications@github.com> Reply-To: aspnet/Home <reply@reply.github.com> To: aspnet/Home <Home@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Message-ID: <aspnet/Home/issues/1926/354574917@github.com> In-Reply-To: <aspnet/Home/issues/1926@github.com> References: <aspnet/Home/issues/1926@github.com> Subject: Re: [aspnet/Home] Asp.net core putting the same Guid for all empty Guid's (#1926) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5a4822e6b1a2e_7793fbb505e8f3023362ae"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: aspnet-hello X-GitHub-Recipient: davidalpert X-GitHub-Reason: subscribed List-ID: aspnet/Home <Home.aspnet.github.com> List-Archive: https://github.com/aspnet/Home List-Post: <mailto:reply@reply.github.com> List-Unsubscribe: <mailto:unsub+0000a944923059621d19c7dd4fdf39b16ade33a80d99cc9992cf00000001165fe4e692a169ce0c3ed8c2@reply.github.com>, <https://github.com/notifications/unsubscribe/AACpRAgeN5oxkywwAcXephDMHXYsmSJoks5tFsjmgaJpZM4L3lis> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: david@spinthemoose.com

----==_mimepart_5a4822e6b1a2e_7793fbb505e8f3023362ae Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This issue is being closed because it has not been updated in 3 months. We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #1926 (comment) ----==_mimepart_5a4822e6b1a2e_7793fbb505e8f3023362ae Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <p>This issue is being closed because it has not been updated in 3 months= .</p> <p>We apologize if this causes any inconvenience. We ask that if you are = still encountering this issue, please log a new issue with updated inform= ation and we will investigate.</p> <p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m= dash;<br />You are receiving this because you are subscribed to this thre= ad.<br />Reply to this email directly, <a href=3D"https://github.com/aspn= et/Home/issues/1926#issuecomment-354574917">view it on GitHub</a>, or <a = href=3D"https://github.com/notifications/unsubscribe-auth/AACpRMDAmE-z0-4= -nYwii7GDcB4bmdCSks5tFsjmgaJpZM4L3lis">mute the thread</a>.<img alt=3D"" = height=3D"1" src=3D"https://github.com/notifications/beacon/AACpRHj805T9N= znXa6S-O-7zgpJ9Dfaiks5tFsjmgaJpZM4L3lis.gif" width=3D"1" /></p> <div itemscope itemtype=3D"http://schema.org/EmailMessage"> <div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/ViewActi= on"> <link itemprop=3D"url" href=3D"#19 26#issuecomment-354574917"></link> <meta itemprop=3D"name" content=3D"View Issue"></meta> </div> <meta itemprop=3D"description" content=3D"View this Issue on GitHub"></me= ta> </div> <script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio= n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"= :"GitHub"},"entity":{"external_key":"github/aspnet/Home","title":"aspnet/= Home","subtitle":"GitHub repository","main_image_url":"https://cloud.gith= ubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c= 7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/= 143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name= ":"Open in GitHub","url":"https://github.com/aspnet/Home"}},"updates":{"s= nippets":[{"icon":"PERSON","message":"@aspnet-hello in #1926: This issue = is being closed because it has not been updated in 3 months.\r\n\r\nWe ap= ologize if this causes any inconvenience. We ask that if you are still en= countering this issue, please log a new issue with updated information an= d we will investigate.\r\n"}],"action":{"name":"View Issue","url":"https:= //github.com/aspnet/Home/issues/1926#issuecomment-354574917"}}}</script>=

----==_mimepart_5a4822e6b1a2e_7793fbb505e8f3023362ae--

[davidalpert]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: spinthemoose@gmail.com Domain spinthemoose.com has exceeded the max emails per hour (217/200 (108%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o5.sgmail.github.com ([192.254.113.10]:33539) by cp1164.blacksun.ca with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from <bounces+848413-6f87-david=spinthemoose.com@sgmail.github.com>) id 1eVQfz-0000GZ-0o for david@spinthemoose.com; Sat, 30 Dec 2017 17:36:27 -0600 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=NLXTiiz+aZmuLXorAXFe+qicUig=; b=FvYDakHGmQay9U2F lG9SBOAJXAz2DNSGimHpom6InaLOlehx7YSN1YwVbWbheVGqZOfqf6qgjfao6jmo vJGAzf+oAUK22ROigZaTcTQ8kkidLAZWLX5HorACBf4klSG7nCQ1U/xfoh/RVkRW UjUK1H032vMyQb5+DgYcLMYwMr4= Received: by filter0553p1mdw1.sendgrid.net with SMTP id filter0553p1mdw1-7336-5A4822E6-2C 2017-12-30 23:36:07.009897893 +0000 UTC Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0022p1iad2.sendgrid.net (SG) with ESMTP id dxDn7d29SiqHFoNiiy-Mdg for <david@spinthemoose.com>; Sat, 30 Dec 2017 23:36:07.018 +0000 (UTC) Date: Sat, 30 Dec 2017 23:36:07 +0000 (UTC) From: "ASP.NET Hello Bot" <notifications@github.com> Reply-To: aspnet/Home <reply@reply.github.com> To: aspnet/Home <Home@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Message-ID: <aspnet/Home/issue/1926/issue_event/1405208081@github.com> In-Reply-To: <aspnet/Home/issues/1926@github.com> References: <aspnet/Home/issues/1926@github.com> Subject: Re: [aspnet/Home] Asp.net core putting the same Guid for all empty Guid's (#1926) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5a4822e6dde79_73ea3f976a148f345609af"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: aspnet-hello X-GitHub-Recipient: davidalpert X-GitHub-Reason: subscribed List-ID: aspnet/Home <Home.aspnet.github.com> List-Archive: https://github.com/aspnet/Home List-Post: <mailto:reply@reply.github.com> List-Unsubscribe: <mailto:unsub+0000a944923059621d19c7dd4fdf39b16ade33a80d99cc9992cf00000001165fe4e692a169ce0c3ed8c2@reply.github.com>, <https://github.com/notifications/unsubscribe/AACpRAgeN5oxkywwAcXephDMHXYsmSJoks5tFsjmgaJpZM4L3lis> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: david@spinthemoose.com X-SG-EID: rlj3t9ahcX0BZUzAOlajQ3VmBXo43xFJc4M1ImIDJhEP4CNgB3kZKMNg4j6gMUh0OjVvtyAEjh7cGa tWwfJgXxhPYFMPewRbYLXl1+PfZfmPyQVQAEqOvdDWlj62GlQHwwJre6v6A+4M1lJaSQtMGAy8k5le 9r1aFzFDRN39thgo+GMoLXSXNW/k0HTtlZ65FBDLUqfeu25539GYrSXCBS+zYdXdg1swSaRYYskdw6 Q=

----==_mimepart_5a4822e6dde79_73ea3f976a148f345609af Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Closed #1926.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #1926 (comment) ----==_mimepart_5a4822e6dde79_73ea3f976a148f345609af Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>Closed <a href="#1926" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="205445314" data-permission-text="Issue title is private" data-url="#1926> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#1926 (comment) it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AACpRMDAmE-z0-4-nYwii7GDcB4bmdCSks5tFsjmgaJpZM4L3lis">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AACpRHj805T9NznXa6S-O-7zgpJ9Dfaiks5tFsjmgaJpZM4L3lis.gif" width="1" /></p> <div itemscope itemtype="http://schema.org/EmailMessage"> <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction"> <link itemprop="url" href="#1926 (comment)> <meta itemprop="name" content="View Issue"></meta> </div> <meta itemprop="description" content="View this Issue on GitHub"></meta> </div> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/aspnet/Home","title":"aspnet/Home","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/aspnet/Home"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #1926."}],"action":{"name":"View Issue","url":"#1926 (comment)> ----==_mimepart_5a4822e6dde79_73ea3f976a148f345609af--