Skip to content

bug(spa): poor Angular messaging #17925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpboyd opened this issue Dec 17, 2019 · 4 comments
Closed

bug(spa): poor Angular messaging #17925

cpboyd opened this issue Dec 17, 2019 · 4 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-spa investigate
Milestone

Comments

@cpboyd
Copy link

cpboyd commented Dec 17, 2019

Describe the bug

When there's a compilation error, the .NET server will simply report a timeout.

To Reproduce

Use the Angular starter project and simply modify the project to not compile.

Further technical details

  • ASP.NET Core version:
    3.1.100
  • Include the output of dotnet --info:
.NET Core SDK (reflecting any global.json):
 Version:   3.1.100
 Commit:    cd82f021f4

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18362
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.1.100\

Host (useful for support):
  Version: 3.1.0
  Commit:  65f04fb6db

.NET Core SDKs installed:
  3.1.100 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download
  • The IDE (VS / VS Code/ VS4Mac) you're running on, and it's version
    Visual Studio 16.4.1
@cpboyd cpboyd changed the title bug(spa): timeout reported on Angular issues bug(spa): timeout reported on Angular compilation failure Dec 17, 2019
@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Dec 17, 2019
@mkArtakMSFT mkArtakMSFT added this to the 5.0.0-preview1 milestone Dec 17, 2019
@mkArtakMSFT
Copy link
Contributor

Thanks for contacting us.
We will consider looking into this during 5.0 release.
However, we will happily consider a community PR for this. So feel free to send one if you want.

@cpboyd
Copy link
Author

cpboyd commented Dec 19, 2019

Just to clarify, the issue occurs when Angular compilation fails (not .NET).

The Angular error shows in the command prompt, but it was kind of confusing to see a timeout error in the browser.

I guess it may not be a "bug" per se, since effectively the Angular server doesn't respond.

It'd just be nice if the SPA extensions could provide a more helpful error message than the vague timeout, which probably leads to reports like #17607

@cpboyd cpboyd changed the title bug(spa): timeout reported on Angular compilation failure bug(spa): poor Angular messaging Dec 23, 2019
@cpboyd
Copy link
Author

cpboyd commented Dec 23, 2019

Another related point: "compiling" messages (probably Ivy specific) are marked in the command prompt with a red "fail", even though they're just Angular denoting progress.

Likewise, an error specifying to clear node_modules never gets mentioned in the command prompt at all.

The timeout message just appears, with no information on how to clear the error.

@mkArtakMSFT
Copy link
Contributor

Thanks for contacting us.
This is not something we plan to do in the near future. You can learn more about our triage process and how we handle issues by reading our Triage Process writeup.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-spa investigate
Projects
None yet
Development

No branches or pull requests

3 participants