Skip to content

dnvminstall.sh should check for ~/.bashrc first #1186

Closed
@fsoikin

Description

@fsoikin

As it is currently coded, dnvminstall.sh first tries to add its hooks to ~/.bash_profile, and only if that doesn't exist, goes for ~/.bashrc. This behavior essentially prevents the hooks from working in non-login terminals (such as Gnome-started graphical one), which source ~/.bashrc, but not ~/.bash_profile.

Doing it the other way around would be beneficial, and not harmful, because ~/.bashrc should normally be sourced from ~/.bash_profile, and indeed, it is usually the default.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions