Add more nullability to Mvc.Core

Author: pranavkm

src/Mvc/Mvc.Abstractions/src/Abstractions/ActionDescriptor.cs

@@ -21,7 +21,7 @@ public ActionDescriptor()
         {
             Id = Guid.NewGuid().ToString();
             Properties = new Dictionary<object, object>();
-            RouteValues = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
+            RouteValues = new Dictionary<string, string?>(StringComparer.OrdinalIgnoreCase);
         }
 
         /// <summary>
@@ -33,7 +33,7 @@ public ActionDescriptor()
         /// Gets or sets the collection of route values that must be provided by routing
         /// for the action to be selected.
         /// </summary>
-        public IDictionary<string, string> RouteValues { get; set; }
+        public IDictionary<string, string?> RouteValues { get; set; }
 
         /// <summary>
         /// Gets or sets the <see cref="Routing.AttributeRouteInfo"/>.

src/Mvc/Mvc.Abstractions/src/Abstractions/ParameterDescriptor.cs

@@ -24,6 +24,6 @@ public class ParameterDescriptor
         /// <summary>
         /// Gets or sets the <see cref="ModelBinding.BindingInfo"/> for the parameter.
         /// </summary>
-        public BindingInfo BindingInfo { get; set; } = default!;
+        public BindingInfo? BindingInfo { get; set; }
     }
 }

src/Mvc/Mvc.Abstractions/src/ActionConstraints/ActionConstraintItem.cs

@@ -28,7 +28,7 @@ public ActionConstraintItem(IActionConstraintMetadata metadata)
         /// <summary>
         /// The <see cref="IActionConstraint"/> associated with <see cref="Metadata"/>.
         /// </summary>
-        public IActionConstraint Constraint { get; set; } = default!;
+        public IActionConstraint? Constraint { get; set; }
 
         /// <summary>
         /// The <see cref="IActionConstraintMetadata"/> instance.
@@ -40,4 +40,4 @@ public ActionConstraintItem(IActionConstraintMetadata metadata)
         /// </summary>
         public bool IsReusable { get; set; }
     }
-}
+}

src/Mvc/Mvc.Abstractions/src/ActionConstraints/ActionSelectorCandidate.cs

@@ -19,7 +19,7 @@ public readonly struct ActionSelectorCandidate
         /// <param name="constraints">
         /// The list of <see cref="IActionConstraint"/> instances associated with <paramref name="action"/>.
         /// </param>
-        public ActionSelectorCandidate(ActionDescriptor action, IReadOnlyList<IActionConstraint> constraints)
+        public ActionSelectorCandidate(ActionDescriptor action, IReadOnlyList<IActionConstraint>? constraints)
         {
             if (action == null)
             {
@@ -38,6 +38,6 @@ public ActionSelectorCandidate(ActionDescriptor action, IReadOnlyList<IActionCon
         /// <summary>
         /// The list of <see cref="IActionConstraint"/> instances associated with <see name="Action"/>.
         /// </summary>
-        public IReadOnlyList<IActionConstraint> Constraints { get; }
+        public IReadOnlyList<IActionConstraint>? Constraints { get; }
     }
-}
+}

src/Mvc/Mvc.Abstractions/src/Filters/FilterItem.cs

@@ -53,7 +53,7 @@ public FilterItem(FilterDescriptor descriptor, IFilterMetadata filter)
         /// <summary>
         /// Gets or sets the executable <see cref="IFilterMetadata"/> associated with <see cref="Descriptor"/>.
         /// </summary>
-        public IFilterMetadata Filter { get; set; } = default!;
+        public IFilterMetadata? Filter { get; set; }
 
         /// <summary>
         /// Gets or sets a value indicating whether or not <see cref="Filter"/> can be reused across requests.

src/Mvc/Mvc.Abstractions/src/Formatters/InputFormatterResult.cs

@@ -20,7 +20,7 @@ private InputFormatterResult(bool hasError)
             HasError = hasError;
         }
 
-        private InputFormatterResult(object model)
+        private InputFormatterResult(object? model)
         {
             Model = model;
             IsModelSet = true;
@@ -79,7 +79,7 @@ public static Task<InputFormatterResult> FailureAsync()
         /// An <see cref="InputFormatterResult"/> indicating the <see cref="IInputFormatter.ReadAsync"/>
         /// operation succeeded i.e. with <see cref="HasError"/> <c>false</c>.
         /// </returns>
-        public static InputFormatterResult Success(object model)
+        public static InputFormatterResult Success(object? model)
         {
             return new InputFormatterResult(model);
         }
@@ -93,7 +93,7 @@ public static InputFormatterResult Success(object model)
         /// A <see cref="Task"/> that on completion provides an <see cref="InputFormatterResult"/> indicating the
         /// <see cref="IInputFormatter.ReadAsync"/> operation succeeded i.e. with <see cref="HasError"/> <c>false</c>.
         /// </returns>
-        public static Task<InputFormatterResult> SuccessAsync(object model)
+        public static Task<InputFormatterResult> SuccessAsync(object? model)
         {
             return Task.FromResult(Success(model));
         }

src/Mvc/Mvc.Abstractions/src/ModelBinding/IBinderTypeProviderMetadata.cs

@@ -13,6 +13,6 @@ public interface IBinderTypeProviderMetadata : IBindingSourceMetadata
         /// <summary>
         /// A <see cref="Type"/> which implements either <see cref="IModelBinder"/>.
         /// </summary>
-        Type BinderType { get; }
+        Type? BinderType { get; }
     }
 }

src/Mvc/Mvc.Abstractions/src/ModelBinding/IModelNameProvider.cs

@@ -11,6 +11,6 @@ public interface IModelNameProvider
         /// <summary>
         /// Model name.
         /// </summary>
-        string Name { get; }
+        string? Name { get; }
     }
 }

src/Mvc/Mvc.Abstractions/src/PublicAPI.Unshipped.txt

@@ -39,8 +39,27 @@
 *REMOVED*virtual Microsoft.AspNetCore.Mvc.Filters.ActionExecutingContext.ActionArguments.get -> System.Collections.Generic.IDictionary<string!, object!>!
 *REMOVED*virtual Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata.BoundConstructorInvoker.get -> System.Func<object![]!, object!>?
 *REMOVED*virtual Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata.ContainerMetadata.get -> Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata!
+*REMOVED*Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.RouteValues.get -> System.Collections.Generic.IDictionary<string!, string!>!
+*REMOVED*Microsoft.AspNetCore.Mvc.Abstractions.ParameterDescriptor.BindingInfo.get -> Microsoft.AspNetCore.Mvc.ModelBinding.BindingInfo!
+*REMOVED*Microsoft.AspNetCore.Mvc.ActionConstraints.ActionConstraintItem.Constraint.get -> Microsoft.AspNetCore.Mvc.ActionConstraints.IActionConstraint!
+*REMOVED*Microsoft.AspNetCore.Mvc.ActionConstraints.ActionSelectorCandidate.ActionSelectorCandidate(Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor! action, System.Collections.Generic.IReadOnlyList<Microsoft.AspNetCore.Mvc.ActionConstraints.IActionConstraint!>! constraints) -> void
+*REMOVED*Microsoft.AspNetCore.Mvc.ActionConstraints.ActionSelectorCandidate.Constraints.get -> System.Collections.Generic.IReadOnlyList<Microsoft.AspNetCore.Mvc.ActionConstraints.IActionConstraint!>!
+*REMOVED*Microsoft.AspNetCore.Mvc.Filters.FilterItem.Filter.get -> Microsoft.AspNetCore.Mvc.Filters.IFilterMetadata!
+*REMOVED*Microsoft.AspNetCore.Mvc.ModelBinding.IBinderTypeProviderMetadata.BinderType.get -> System.Type!
+*REMOVED*Microsoft.AspNetCore.Mvc.ModelBinding.IModelNameProvider.Name.get -> string!
+*REMOVED*Microsoft.AspNetCore.Mvc.Routing.AttributeRouteInfo.Name.get -> string!
+*REMOVED*static Microsoft.AspNetCore.Mvc.Formatters.InputFormatterResult.Success(object! model) -> Microsoft.AspNetCore.Mvc.Formatters.InputFormatterResult!
+*REMOVED*static Microsoft.AspNetCore.Mvc.Formatters.InputFormatterResult.SuccessAsync(object! model) -> System.Threading.Tasks.Task<Microsoft.AspNetCore.Mvc.Formatters.InputFormatterResult!>!
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.RouteValues.get -> System.Collections.Generic.IDictionary<string!, string?>!
+Microsoft.AspNetCore.Mvc.Abstractions.ParameterDescriptor.BindingInfo.get -> Microsoft.AspNetCore.Mvc.ModelBinding.BindingInfo?
+Microsoft.AspNetCore.Mvc.ActionConstraints.ActionConstraintItem.Constraint.get -> Microsoft.AspNetCore.Mvc.ActionConstraints.IActionConstraint?
+Microsoft.AspNetCore.Mvc.ActionConstraints.ActionSelectorCandidate.ActionSelectorCandidate(Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor! action, System.Collections.Generic.IReadOnlyList<Microsoft.AspNetCore.Mvc.ActionConstraints.IActionConstraint!>? constraints) -> void
+Microsoft.AspNetCore.Mvc.ActionConstraints.ActionSelectorCandidate.Constraints.get -> System.Collections.Generic.IReadOnlyList<Microsoft.AspNetCore.Mvc.ActionConstraints.IActionConstraint!>?
 Microsoft.AspNetCore.Mvc.Filters.ActionExecutingContext.ActionExecutingContext(Microsoft.AspNetCore.Mvc.ActionContext! actionContext, System.Collections.Generic.IList<Microsoft.AspNetCore.Mvc.Filters.IFilterMetadata!>! filters, System.Collections.Generic.IDictionary<string!, object?>! actionArguments, object! controller) -> void
+Microsoft.AspNetCore.Mvc.Filters.FilterItem.Filter.get -> Microsoft.AspNetCore.Mvc.Filters.IFilterMetadata?
 Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext.OutputFormatterWriteContext(Microsoft.AspNetCore.Http.HttpContext! httpContext, System.Func<System.IO.Stream!, System.Text.Encoding!, System.IO.TextWriter!>! writerFactory, System.Type? objectType, object? object) -> void
+Microsoft.AspNetCore.Mvc.ModelBinding.IBinderTypeProviderMetadata.BinderType.get -> System.Type?
+Microsoft.AspNetCore.Mvc.ModelBinding.IModelNameProvider.Name.get -> string?
 Microsoft.AspNetCore.Mvc.ModelBinding.ModelStateDictionary.SetModelValue(string! key, object? rawValue, string? attemptedValue) -> void
 Microsoft.AspNetCore.Mvc.ModelBinding.ModelStateDictionary.this[string! key].get -> Microsoft.AspNetCore.Mvc.ModelBinding.ModelStateEntry?
 Microsoft.AspNetCore.Mvc.ModelBinding.Validation.ClientValidatorItem.ClientValidatorItem(object? validatorMetadata) -> void
@@ -53,6 +72,7 @@ Microsoft.AspNetCore.Mvc.ModelBinding.Validation.ValidationEntry.ValidationEntry
 Microsoft.AspNetCore.Mvc.ModelBinding.Validation.ValidationEntry.ValidationEntry(Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata! metadata, string! key, object? model) -> void
 Microsoft.AspNetCore.Mvc.ModelBinding.Validation.ValidatorItem.Validator.get -> Microsoft.AspNetCore.Mvc.ModelBinding.Validation.IModelValidator?
 Microsoft.AspNetCore.Mvc.ModelBinding.ValueProviderResult.ValueProviderResult(Microsoft.Extensions.Primitives.StringValues values, System.Globalization.CultureInfo? culture) -> void
+Microsoft.AspNetCore.Mvc.Routing.AttributeRouteInfo.Name.get -> string?
 abstract Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext.BinderModelName.get -> string?
 abstract Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext.BindingSource.get -> Microsoft.AspNetCore.Mvc.ModelBinding.BindingSource?
 abstract Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext.EnterNestedScope(Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata! modelMetadata, string! fieldName, string! modelName, object? model) -> Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext.NestedScope
@@ -75,6 +95,8 @@ abstract Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata.PropertyGetter.get
 abstract Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata.PropertySetter.get -> System.Action<object!, object?>?
 abstract Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata.SimpleDisplayProperty.get -> string?
 abstract Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata.TemplateHint.get -> string?
+static Microsoft.AspNetCore.Mvc.Formatters.InputFormatterResult.Success(object? model) -> Microsoft.AspNetCore.Mvc.Formatters.InputFormatterResult!
+static Microsoft.AspNetCore.Mvc.Formatters.InputFormatterResult.SuccessAsync(object? model) -> System.Threading.Tasks.Task<Microsoft.AspNetCore.Mvc.Formatters.InputFormatterResult!>!
 virtual Microsoft.AspNetCore.Mvc.Filters.ActionExecutedContext.Result.get -> Microsoft.AspNetCore.Mvc.IActionResult?
 virtual Microsoft.AspNetCore.Mvc.Filters.ActionExecutingContext.ActionArguments.get -> System.Collections.Generic.IDictionary<string!, object?>!
 virtual Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata.BoundConstructorInvoker.get -> System.Func<object?[]!, object!>?

src/Mvc/Mvc.Abstractions/src/Routing/AttributeRouteInfo.cs

@@ -27,7 +27,7 @@ public class AttributeRouteInfo
         /// to generate a link by referring to the route by name instead of attempting to match a
         /// route by provided route data.
         /// </summary>
-        public string Name { get; set; } = default!;
+        public string? Name { get; set; }
 
         /// <summary>
         /// Gets or sets a value that determines if the route entry associated with this model participates in link generation.