Remove ChangeToken from EndpointDataSource (#662)

Author: JamesNK

src/Microsoft.AspNetCore.Routing/CompositeEndpointDataSource.cs

@@ -34,8 +34,6 @@ internal CompositeEndpointDataSource(IEnumerable<EndpointDataSource> dataSources
             _lock = new object();
         }
 
-        public override IChangeToken ChangeToken => GetChangeToken();
-
         public override IChangeToken GetChangeToken()
         {
             EnsureInitialized();

src/Microsoft.AspNetCore.Routing/DefaultEndpointDataSource.cs

@@ -23,8 +23,6 @@ public DefaultEndpointDataSource(IEnumerable<Endpoint> endpoints)
             _endpoints.AddRange(endpoints);
         }
 
-        public override IChangeToken ChangeToken => GetChangeToken();
-
         public override IChangeToken GetChangeToken() => NullChangeToken.Singleton;
 
         public override IReadOnlyList<Endpoint> Endpoints => _endpoints;

src/Microsoft.AspNetCore.Routing/EndpointDataSource.cs

@@ -8,15 +8,7 @@ namespace Microsoft.AspNetCore.Routing
 {
     public abstract class EndpointDataSource
     {
-        public virtual IChangeToken ChangeToken { get; }
-
-        // Plan is to replace ChangeToken property with GetChangeToken
-        // Temporarily have both to avoid breaking MVC
-        // https://github.com/aspnet/Routing/issues/634
-        public virtual IChangeToken GetChangeToken()
-        {
-            return ChangeToken;
-        }
+        public abstract IChangeToken GetChangeToken();
 
         public abstract IReadOnlyList<Endpoint> Endpoints { get; }
     }

test/Microsoft.AspNetCore.Routing.Tests/CompositeEndpointDataSourceTest.cs

@@ -174,7 +174,6 @@ public CustomEndpointDataSource()
             }
 
             public override IChangeToken GetChangeToken() => _token;
-            public override IChangeToken ChangeToken => GetChangeToken();
             public override IReadOnlyList<Endpoint> Endpoints => Array.Empty<Endpoint>();
         }
     }

test/Microsoft.AspNetCore.Routing.Tests/TestObjects/DynamicEndpointDataSource.cs

@@ -25,8 +25,6 @@ public DynamicEndpointDataSource(params Endpoint[] endpoints)
 
         public override IChangeToken GetChangeToken() => _changeToken;
 
-        public override IChangeToken ChangeToken => GetChangeToken();
-
         public override IReadOnlyList<Endpoint> Endpoints => _endpoints;
 
         // Trigger change