Add nullable annotations to Microsoft.AspNetCore.Mvc.Abstractions

Contributes to #5680

Author: pranavkm

src/Mvc/Mvc.Abstractions/ref/Microsoft.AspNetCore.Mvc.Abstractions.csproj

@@ -2,6 +2,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks>
+    <Nullable>annotations</Nullable>
   </PropertyGroup>
   <ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'">
     <Compile Include="Microsoft.AspNetCore.Mvc.Abstractions.netcoreapp.cs" />

src/Mvc/Mvc.Abstractions/ref/Microsoft.AspNetCore.Mvc.Abstractions.netcoreapp.cs

@@ -38,42 +38,42 @@ public ActionDescriptor()
         /// <summary>
         /// Gets or sets the <see cref="Routing.AttributeRouteInfo"/>.
         /// </summary>
-        public AttributeRouteInfo AttributeRouteInfo { get; set; }
+        public AttributeRouteInfo? AttributeRouteInfo { get; set; }
 
         /// <summary>
         /// The set of constraints for this action. Must all be satisfied for the action to be selected.
         /// </summary>
-        public IList<IActionConstraintMetadata> ActionConstraints { get; set; }
+        public IList<IActionConstraintMetadata>? ActionConstraints { get; set; }
 
         /// <summary>
         /// Gets or sets the endpoint metadata for this action.
         /// This API is meant for infrastructure and should not be used by application code.
         /// </summary>
-        public IList<object> EndpointMetadata { get; set; }
+        public IList<object>? EndpointMetadata { get; set; }
 
         /// <summary>
         /// The set of parameters associated with this action.
         /// </summary>
-        public IList<ParameterDescriptor> Parameters { get; set; }
+        public IList<ParameterDescriptor> Parameters { get; set; } = Array.Empty<ParameterDescriptor>();
 
         /// <summary>
         /// The set of properties which are model bound.
         /// </summary>
-        public IList<ParameterDescriptor> BoundProperties { get; set; }
+        public IList<ParameterDescriptor> BoundProperties { get; set; } = Array.Empty<ParameterDescriptor>();
 
         /// <summary>
         /// The set of filters associated with this action.
         /// </summary>
-        public IList<FilterDescriptor> FilterDescriptors { get; set; }
+        public IList<FilterDescriptor> FilterDescriptors { get; set; } = Array.Empty<FilterDescriptor>();
 
         /// <summary>
         /// A friendly name for this action.
         /// </summary>
-        public virtual string DisplayName { get; set; }
+        public virtual string DisplayName { get; set; } = default!;
 
         /// <summary>
         /// Stores arbitrary metadata properties associated with the <see cref="ActionDescriptor"/>.
         /// </summary>
-        public IDictionary<object, object> Properties { get; set; }
+        public IDictionary<object, object> Properties { get; set; } = default!;
     }
 }

src/Mvc/Mvc.Abstractions/src/Abstractions/ActionDescriptor.cs

@@ -24,14 +24,13 @@ public static T GetProperty<T>(this ActionDescriptor actionDescriptor)
                 throw new ArgumentNullException(nameof(actionDescriptor));
             }
 
-            object value;
-            if (actionDescriptor.Properties.TryGetValue(typeof(T), out value))
+            if (actionDescriptor.Properties.TryGetValue(typeof(T), out var value))
             {
                 return (T)value;
             }
             else
             {
-                return default(T);
+                return default!;
             }
         }
 

src/Mvc/Mvc.Abstractions/src/Abstractions/ActionDescriptorExtensions.cs

@@ -32,6 +32,6 @@ public ActionInvokerProviderContext(ActionContext actionContext)
         /// <summary>
         /// Gets or sets the <see cref="IActionInvoker"/> that will be used to invoke <see cref="ActionContext" />
         /// </summary>
-        public IActionInvoker Result { get; set; }
+        public IActionInvoker? Result { get; set; }
     }
 }

src/Mvc/Mvc.Abstractions/src/Abstractions/ActionInvokerProviderContext.cs

@@ -14,16 +14,16 @@ public class ParameterDescriptor
         /// <summary>
         /// Gets or sets the parameter name.
         /// </summary>
-        public string Name { get; set; }
+        public string Name { get; set; } = default!;
 
         /// <summary>
         /// Gets or sets the type of the parameter.
         /// </summary>
-        public Type ParameterType { get; set; }
+        public Type ParameterType { get; set; } = default!;
 
         /// <summary>
         /// Gets or sets the <see cref="ModelBinding.BindingInfo"/> for the parameter.
         /// </summary>
-        public BindingInfo BindingInfo { get; set; }
+        public BindingInfo BindingInfo { get; set; } = default!;
     }
 }

src/Mvc/Mvc.Abstractions/src/Abstractions/ParameterDescriptor.cs

@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System;
 using System.Collections.Generic;
 using Microsoft.AspNetCore.Routing;
 
@@ -15,16 +16,16 @@ public class ActionConstraintContext
         /// The list of <see cref="ActionSelectorCandidate"/>. This includes all actions that are valid for the current
         /// request, as well as their constraints.
         /// </summary>
-        public IReadOnlyList<ActionSelectorCandidate> Candidates { get; set; }
+        public IReadOnlyList<ActionSelectorCandidate> Candidates { get; set; } = Array.Empty<ActionSelectorCandidate>();
 
         /// <summary>
         /// The current <see cref="ActionSelectorCandidate"/>.
         /// </summary>
-        public ActionSelectorCandidate CurrentCandidate { get; set; }
+        public ActionSelectorCandidate CurrentCandidate { get; set; } = default!;
 
         /// <summary>
         /// The <see cref="RouteContext"/>.
         /// </summary>
-        public RouteContext RouteContext { get; set; }
+        public RouteContext RouteContext { get; set; } = default!;
     }
 }

src/Mvc/Mvc.Abstractions/src/ActionConstraints/ActionConstraintContext.cs

@@ -28,7 +28,7 @@ public ActionConstraintItem(IActionConstraintMetadata metadata)
         /// <summary>
         /// The <see cref="IActionConstraint"/> associated with <see cref="Metadata"/>.
         /// </summary>
-        public IActionConstraint Constraint { get; set; }
+        public IActionConstraint Constraint { get; set; } = default!;
 
         /// <summary>
         /// The <see cref="IActionConstraintMetadata"/> instance.

src/Mvc/Mvc.Abstractions/src/ActionConstraints/ActionConstraintItem.cs

@@ -31,10 +31,10 @@ public ActionContext()
         /// <param name="actionContext">The <see cref="ActionContext"/> to copy.</param>
         public ActionContext(ActionContext actionContext)
             : this(
-                actionContext?.HttpContext,
-                actionContext?.RouteData,
-                actionContext?.ActionDescriptor,
-                actionContext?.ModelState)
+                actionContext?.HttpContext!,
+                actionContext?.RouteData!,
+                actionContext?.ActionDescriptor!,
+                actionContext?.ModelState!)
         {
         }
 
@@ -97,39 +97,27 @@ public ActionContext(
         /// <remarks>
         /// The property setter is provided for unit test purposes only.
         /// </remarks>
-        public ActionDescriptor ActionDescriptor
-        {
-            get; set;
-        }
+        public ActionDescriptor ActionDescriptor { get; set; } = default!;
 
         /// <summary>
         /// Gets or sets the <see cref="Http.HttpContext"/> for the current request.
         /// </summary>
         /// <remarks>
         /// The property setter is provided for unit test purposes only.
         /// </remarks>
-        public HttpContext HttpContext
-        {
-            get; set;
-        }
+        public HttpContext HttpContext { get; set; } = default!;
 
         /// <summary>
         /// Gets the <see cref="ModelStateDictionary"/>.
         /// </summary>
-        public ModelStateDictionary ModelState
-        {
-            get;
-        }
+        public ModelStateDictionary ModelState { get; } = default!;
 
         /// <summary>
         /// Gets or sets the <see cref="AspNetCore.Routing.RouteData"/> for the current request.
         /// </summary>
         /// <remarks>
         /// The property setter is provided for unit test purposes only.
         /// </remarks>
-        public RouteData RouteData
-        {
-            get; set;
-        }
+        public RouteData RouteData { get; set; } = default!;
     }
 }

src/Mvc/Mvc.Abstractions/src/ActionContext.cs

@@ -16,17 +16,17 @@ public class ApiDescription
         /// <summary>
         /// Gets or sets <see cref="ActionDescriptor"/> for this api.
         /// </summary>
-        public ActionDescriptor ActionDescriptor { get; set; }
+        public ActionDescriptor ActionDescriptor { get; set; } = default!;
 
         /// <summary>
         /// Gets or sets group name for this api.
         /// </summary>
-        public string GroupName { get; set; }
+        public string? GroupName { get; set; }
 
         /// <summary>
         /// Gets or sets the supported HTTP method for this api, or null if all HTTP methods are supported.
         /// </summary>
-        public string HttpMethod { get; set; }
+        public string? HttpMethod { get; set; }
 
         /// <summary>
         /// Gets a list of <see cref="ApiParameterDescription"/> for this api.
@@ -41,7 +41,7 @@ public class ApiDescription
         /// <summary>
         /// Gets or sets relative url path template (relative to application root) for this api.
         /// </summary>
-        public string RelativePath { get; set; }
+        public string RelativePath { get; set; } = default!;
 
         /// <summary>
         /// Gets the list of possible formats for a request.