[AOT] Fix runtime warnings (#45604)

Co-authored-by: Stephen Halter <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Andrew Casey <[email protected]>

Author: 4 people

Directory.Build.targets

@@ -3,13 +3,15 @@
     <!-- Only build Microsoft.AspNetCore.App, Microsoft.AspNetCore.App.Ref, ref/ assemblies, and ProjectTemplates in source build. -->
     <!-- Analyzer package are needed in source build for WebSDK -->
     <ExcludeFromSourceBuild
-        Condition="'$(ExcludeFromSourceBuild)' == '' and 
-            '$(DotNetBuildFromSource)' == 'true' and 
-            '$(IsAspNetCoreApp)' != 'true' and 
-            '$(MSBuildProjectName)' != '$(TargetingPackName)' and 
-            '$(IsAnalyzersProject)' != 'true' and 
+        Condition="'$(ExcludeFromSourceBuild)' == '' and
+            '$(DotNetBuildFromSource)' == 'true' and
+            '$(IsAspNetCoreApp)' != 'true' and
+            '$(MSBuildProjectName)' != '$(TargetingPackName)' and
+            '$(IsAnalyzersProject)' != 'true' and
             '$(IsProjectTemplateProject)' != 'true'">true</ExcludeFromSourceBuild>
 
+    <EnableAOTAnalyzer Condition=" '$(EnableAOTAnalyzer)' == '' ">$([MSBuild]::ValueOrDefault($(IsTrimmable),'false'))</EnableAOTAnalyzer>
+
     <!-- If the user has specified that they want to skip building any test related projects with SkipTestBuild,
      suppress all targets for TestProjects using ExcludeFromBuild. -->
     <ExcludeFromBuild Condition="'$(IsPackable)' != 'true' and

src/Components/Components/src/Microsoft.AspNetCore.Components.csproj

@@ -8,6 +8,7 @@
     <Nullable>enable</Nullable>
     <IsTrimmable>true</IsTrimmable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <EnableAOTAnalyzer>false</EnableAOTAnalyzer>
   </PropertyGroup>
 
   <ItemGroup>

src/Components/Web/src/Microsoft.AspNetCore.Components.Web.csproj

@@ -8,6 +8,7 @@
     <RootNamespace>Microsoft.AspNetCore.Components</RootNamespace>
     <Nullable>enable</Nullable>
     <IsTrimmable>true</IsTrimmable>
+    <EnableAOTAnalyzer>false</EnableAOTAnalyzer>
   </PropertyGroup>
 
   <ItemGroup>

src/Components/WebAssembly/JSInterop/src/Microsoft.JSInterop.WebAssembly.csproj

@@ -8,6 +8,7 @@
     <IsShippingPackage>true</IsShippingPackage>
     <Nullable>enable</Nullable>
     <IsTrimmable>true</IsTrimmable>
+    <EnableAOTAnalyzer>false</EnableAOTAnalyzer>
   </PropertyGroup>
 
   <ItemGroup>

src/Components/WebAssembly/WebAssembly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj

@@ -9,6 +9,7 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <IsTrimmable>true</IsTrimmable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <EnableAOTAnalyzer>false</EnableAOTAnalyzer>
   </PropertyGroup>
 
   <ItemGroup>

src/Components/WebAssembly/WebAssembly/src/Microsoft.AspNetCore.Components.WebAssembly.csproj

@@ -10,6 +10,7 @@
     <Nullable>enable</Nullable>
     <IsTrimmable>true</IsTrimmable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <EnableAOTAnalyzer>false</EnableAOTAnalyzer>
   </PropertyGroup>
 
   <ItemGroup>

src/DataProtection/DataProtection/src/AuthenticatedEncryption/ManagedAuthenticatedEncryptorFactory.cs

@@ -63,6 +63,7 @@ private Func<KeyedHashAlgorithm> GetKeyedHashAlgorithmFactory(ManagedAuthenticat
             throw Error.Common_PropertyCannotBeNullOrEmpty(nameof(configuration.ValidationAlgorithmType));
         }
 
+        typeof(KeyedHashAlgorithm).AssertIsAssignableFrom(configuration.ValidationAlgorithmType);
         _logger.UsingManagedKeyedHashAlgorithm(configuration.ValidationAlgorithmType.FullName!);
         if (configuration.ValidationAlgorithmType == typeof(HMACSHA256))
         {
@@ -111,7 +112,8 @@ private static class AlgorithmActivator
         /// <summary>
         /// Creates a factory that wraps a call to <see cref="Activator.CreateInstance{T}"/>.
         /// </summary>
-        public static Func<T> CreateFactory<T>([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] Type implementation)
+        [UnconditionalSuppressMessage("AOT", "IL3050", Justification = "MakeGenericType is safe to use because implementation is either a KeyedHashAlgorithm or SymmetricAlgorithm type.")]
+        public static Func<T> CreateFactory<T>([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] Type implementation) where T : class
         {
             return ((IActivator<T>)Activator.CreateInstance(typeof(AlgorithmActivatorCore<>).MakeGenericType(implementation))!).Creator;
         }

src/DataProtection/Extensions/src/DataProtectionProvider.cs

@@ -172,6 +172,9 @@ internal static IDataProtectionProvider CreateProvider(
         setupAction(builder);
 
         // extract the provider instance from the service collection
+        // TODO: Remove when DI no longer has RequiresDynamicCodeAttribute https://github.com/dotnet/runtime/pull/79425
+#pragma warning disable IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
         return serviceCollection.BuildServiceProvider().GetRequiredService<IDataProtectionProvider>();
+#pragma warning restore IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
     }
 }

src/DefaultBuilder/src/WebApplicationBuilder.cs

@@ -33,6 +33,8 @@ internal WebApplicationBuilder(WebApplicationOptions options, Action<IHostBuilde
 
         configuration.AddEnvironmentVariables(prefix: "ASPNETCORE_");
 
+        // TODO: Remove when DI no longer has RequiresDynamicCodeAttribute https://github.com/dotnet/runtime/pull/79425
+#pragma warning disable IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
         _hostApplicationBuilder = new HostApplicationBuilder(new HostApplicationBuilderSettings
         {
             Args = options.Args,
@@ -41,6 +43,7 @@ internal WebApplicationBuilder(WebApplicationOptions options, Action<IHostBuilde
             ContentRootPath = options.ContentRootPath,
             Configuration = configuration,
         });
+#pragma warning restore IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
 
         // Set WebRootPath if necessary
         if (options.WebRootPath is not null)

src/Hosting/Hosting/src/GenericHost/GenericWebHostBuilder.cs

@@ -4,6 +4,7 @@
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
+using System.Runtime.CompilerServices;
 using System.Runtime.ExceptionServices;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting.Builder;
@@ -210,7 +211,10 @@ public IWebHostBuilder UseDefaultServiceProvider(Action<WebHostBuilderContext, S
             var webHostBuilderContext = GetWebHostBuilderContext(context);
             var options = new ServiceProviderOptions();
             configure(webHostBuilderContext, options);
+            // TODO: Remove when DI no longer has RequiresDynamicCodeAttribute https://github.com/dotnet/runtime/pull/79425
+#pragma warning disable IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
             return new DefaultServiceProviderFactory(options);
+#pragma warning restore IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
         });
 
         return this;
@@ -267,7 +271,6 @@ void ConfigureStartup(HostBuilderContext context, IServiceCollection services)
         return this;
     }
 
-    [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2006:UnrecognizedReflectionPattern", Justification = "We need to call a generic method on IHostBuilder.")]
     private void UseStartup([DynamicallyAccessedMembers(StartupLinkerOptions.Accessibility)] Type startupType, HostBuilderContext context, IServiceCollection services, object? instance = null)
     {
         var webHostBuilderContext = GetWebHostBuilderContext(context);
@@ -302,21 +305,10 @@ private void UseStartup([DynamicallyAccessedMembers(StartupLinkerOptions.Accessi
             var configureContainerBuilder = StartupLoader.FindConfigureContainerDelegate(startupType, context.HostingEnvironment.EnvironmentName);
             if (configureContainerBuilder.MethodInfo != null)
             {
-                var containerType = configureContainerBuilder.GetContainerType();
                 // Store the builder in the property bag
                 _builder.Properties[typeof(ConfigureContainerBuilder)] = configureContainerBuilder;
 
-                var actionType = typeof(Action<,>).MakeGenericType(typeof(HostBuilderContext), containerType);
-
-                // Get the private ConfigureContainer method on this type then close over the container type
-                var configureCallback = typeof(GenericWebHostBuilder).GetMethod(nameof(ConfigureContainerImpl), BindingFlags.NonPublic | BindingFlags.Instance)!
-                                                 .MakeGenericMethod(containerType)
-                                                 .CreateDelegate(actionType, this);
-
-                // _builder.ConfigureContainer<T>(ConfigureContainer);
-                typeof(IHostBuilder).GetMethod(nameof(IHostBuilder.ConfigureContainer))!
-                    .MakeGenericMethod(containerType)
-                    .InvokeWithoutWrappingExceptions(_builder, new object[] { configureCallback });
+                InvokeContainer(this, configureContainerBuilder);
             }
 
             // Resolve Configure after calling ConfigureServices and ConfigureContainer
@@ -342,6 +334,30 @@ private void UseStartup([DynamicallyAccessedMembers(StartupLinkerOptions.Accessi
                 }
             };
         });
+
+        [UnconditionalSuppressMessage("AOT", "IL3050:RequiresDynamicCode",
+            Justification = "There is a runtime check for ValueType startup container. It's unlikely anyone will use a ValueType here.")]
+        static void InvokeContainer(GenericWebHostBuilder genericWebHostBuilder, ConfigureContainerBuilder configureContainerBuilder)
+        {
+            var containerType = configureContainerBuilder.GetContainerType();
+
+            if (containerType.IsValueType && !RuntimeFeature.IsDynamicCodeSupported)
+            {
+                throw new InvalidOperationException("A ValueType TContainerBuilder isn't supported with AOT.");
+            }
+
+            var actionType = typeof(Action<,>).MakeGenericType(typeof(HostBuilderContext), containerType);
+
+            // Get the private ConfigureContainer method on this type then close over the container type
+            var configureCallback = typeof(GenericWebHostBuilder).GetMethod(nameof(ConfigureContainerImpl), BindingFlags.NonPublic | BindingFlags.Instance)!
+                                             .MakeGenericMethod(containerType)
+                                             .CreateDelegate(actionType, genericWebHostBuilder);
+
+            // _builder.ConfigureContainer<T>(ConfigureContainer);
+            typeof(IHostBuilder).GetMethod(nameof(IHostBuilder.ConfigureContainer))!
+                .MakeGenericMethod(containerType)
+                .InvokeWithoutWrappingExceptions(genericWebHostBuilder._builder, new object[] { configureCallback });
+        }
     }
 
     private void ConfigureContainerImpl<TContainer>(HostBuilderContext context, TContainer container) where TContainer : notnull

src/Hosting/Hosting/src/Internal/StartupLoader.cs

@@ -5,6 +5,7 @@
 using System.Globalization;
 using System.Linq;
 using System.Reflection;
+using System.Runtime.CompilerServices;
 using Microsoft.AspNetCore.Hosting.Internal;
 using Microsoft.Extensions.DependencyInjection;
 
@@ -54,13 +55,26 @@ public static StartupMethods LoadMethods(IServiceProvider hostingServiceProvider
         var type = configureContainerMethod.MethodInfo != null ? configureContainerMethod.GetContainerType() : typeof(object);
 
         var builder = (ConfigureServicesDelegateBuilder)Activator.CreateInstance(
-            typeof(ConfigureServicesDelegateBuilder<>).MakeGenericType(type),
+            CreateConfigureServicesDelegateBuilder(type),
             hostingServiceProvider,
             servicesMethod,
             configureContainerMethod,
             instance)!;
 
         return new StartupMethods(instance, configureMethod.Build(instance), builder.Build());
+
+        [return: DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)]
+        [UnconditionalSuppressMessage("AOT", "IL3050:RequiresDynamicCode",
+            Justification = "There is a runtime check for ValueType startup container. It's unlikely anyone will use a ValueType here.")]
+        static Type CreateConfigureServicesDelegateBuilder(Type type)
+        {
+            if (type.IsValueType && !RuntimeFeature.IsDynamicCodeSupported)
+            {
+                throw new InvalidOperationException("ValueType startup container isn't supported with AOT.");
+            }
+
+            return typeof(ConfigureServicesDelegateBuilder<>).MakeGenericType(type);
+        }
     }
 
     private abstract class ConfigureServicesDelegateBuilder
@@ -146,7 +160,10 @@ IServiceProvider ConfigureServicesWithContainerConfiguration(IServiceCollection
                     applicationServiceProvider = serviceProviderFactory.CreateServiceProvider(builder);
                 }
 
+                // TODO: Remove when DI no longer has RequiresDynamicCodeAttribute https://github.com/dotnet/runtime/pull/79425
+#pragma warning disable IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
                 return applicationServiceProvider ?? services.BuildServiceProvider();
+#pragma warning restore IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
             }
         }
 

src/Hosting/Hosting/src/Internal/WebHost.cs

@@ -115,7 +115,10 @@ public void Initialize()
             // EnsureApplicationServices may have failed due to a missing or throwing Startup class.
             if (_applicationServices == null)
             {
+                // TODO: Remove when DI no longer has RequiresDynamicCodeAttribute https://github.com/dotnet/runtime/pull/79425
+#pragma warning disable IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
                 _applicationServices = _applicationServiceCollection.BuildServiceProvider();
+#pragma warning restore IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
             }
 
             if (!_options.CaptureStartupErrors)

src/Hosting/Hosting/src/Startup/StartupBase.cs

@@ -38,7 +38,10 @@ public virtual void ConfigureServices(IServiceCollection services)
     /// <returns>The <see cref="IServiceProvider"/>.</returns>
     public virtual IServiceProvider CreateServiceProvider(IServiceCollection services)
     {
+        // TODO: Remove when DI no longer has RequiresDynamicCodeAttribute https://github.com/dotnet/runtime/pull/79425
+#pragma warning disable IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
         return services.BuildServiceProvider();
+#pragma warning restore IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
     }
 }
 

src/Hosting/Hosting/src/WebHostBuilder.cs

@@ -200,7 +200,10 @@ public IWebHost Build()
 
         static IServiceProvider GetProviderFromFactory(IServiceCollection collection)
         {
+            // TODO: Remove when DI no longer has RequiresDynamicCodeAttribute https://github.com/dotnet/runtime/pull/79425
+#pragma warning disable IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
             var provider = collection.BuildServiceProvider();
+#pragma warning restore IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
             var factory = provider.GetService<IServiceProviderFactory<IServiceCollection>>();
 
             if (factory != null && factory is not DefaultServiceProviderFactory)

src/Hosting/Hosting/src/WebHostBuilderExtensions.cs

@@ -216,7 +216,10 @@ public static IWebHostBuilder UseDefaultServiceProvider(this IWebHostBuilder hos
         {
             var options = new ServiceProviderOptions();
             configure(context, options);
+            // TODO: Remove when DI no longer has RequiresDynamicCodeAttribute https://github.com/dotnet/runtime/pull/79425
+#pragma warning disable IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
             services.Replace(ServiceDescriptor.Singleton<IServiceProviderFactory<IServiceCollection>>(new DefaultServiceProviderFactory(options)));
+#pragma warning restore IL3050 // Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.
         });
     }
 

src/Hosting/Hosting/test/Internal/MyContainer.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using Microsoft.Extensions.DependencyInjection;

src/Http/Http.Abstractions/src/ProblemDetails/ProblemDetails.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics.CodeAnalysis;
 using System.Text.Json.Serialization;
 using Microsoft.AspNetCore.Http;
 
@@ -12,6 +13,8 @@ namespace Microsoft.AspNetCore.Mvc;
 [JsonConverter(typeof(ProblemDetailsJsonConverter))]
 public class ProblemDetails
 {
+    private readonly IDictionary<string, object?> _extensions = new Dictionary<string, object?>(StringComparer.Ordinal);
+
     /// <summary>
     /// A URI reference [RFC3986] that identifies the problem type. This specification encourages that, when
     /// dereferenced, it provide human-readable documentation for the problem type
@@ -59,5 +62,10 @@ public class ProblemDetails
     /// In particular, complex types or collection types may not round-trip to the original type when using the built-in JSON or XML formatters.
     /// </remarks>
     [JsonExtensionData]
-    public IDictionary<string, object?> Extensions { get; } = new Dictionary<string, object?>(StringComparer.Ordinal);
+    public IDictionary<string, object?> Extensions
+    {
+        [RequiresUnreferencedCode("JSON serialization and deserialization of ProblemDetails.Extensions might require types that cannot be statically analyzed.")]
+        [RequiresDynamicCode("JSON serialization and deserialization of ProblemDetails.Extensions might require types that cannot be statically analyzed.")]
+        get => _extensions;
+    }
 }

src/Http/Http.Abstractions/src/Routing/RouteValueDictionary.cs

@@ -818,12 +818,12 @@ public void Reset()
         }
     }
 
+    [RequiresUnreferencedCode("This API is not trim safe - from PropertyHelper")]
     internal sealed class PropertyStorage
     {
         public readonly object Value;
         public readonly PropertyHelper[] Properties;
 
-        [RequiresUnreferencedCode("This API is not trim safe.")]
         public PropertyStorage(object value)
         {
             Debug.Assert(value != null);