Skip to content

Commit 26d284a

Browse files
authored
Continue using typeof(void) for empty results (#43990)
1 parent 21716e1 commit 26d284a

11 files changed

+13
-2
lines changed

src/Http/Http.Results/test/AcceptedAtRouteResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
8585
// Assert
8686
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
8787
Assert.Equal(StatusCodes.Status202Accepted, producesResponseTypeMetadata.StatusCode);
88+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
8889
}
8990

9091
[Fact]

src/Http/Http.Results/test/AcceptedResultTests.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
4141
PopulateMetadata<Accepted>(((Delegate)MyApi).GetMethodInfo(), builder);
4242

4343
// Assert
44-
Assert.Contains(builder.Metadata, m => m is ProducesResponseTypeMetadata { StatusCode: StatusCodes.Status202Accepted });
44+
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
45+
Assert.Equal(StatusCodes.Status202Accepted, producesResponseTypeMetadata.StatusCode);
46+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
4547
}
4648

4749
[Fact]

src/Http/Http.Results/test/BadRequestResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
5656
// Assert
5757
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
5858
Assert.Equal(StatusCodes.Status400BadRequest, producesResponseTypeMetadata.StatusCode);
59+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
5960
}
6061

6162
[Fact]

src/Http/Http.Results/test/ConflictResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
5757
// Assert
5858
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
5959
Assert.Equal(StatusCodes.Status409Conflict, producesResponseTypeMetadata.StatusCode);
60+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
6061
}
6162

6263
[Fact]

src/Http/Http.Results/test/CreatedAtRouteResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
8181
// Assert
8282
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
8383
Assert.Equal(StatusCodes.Status201Created, producesResponseTypeMetadata.StatusCode);
84+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
8485
}
8586

8687
[Fact]

src/Http/Http.Results/test/CreatedResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
7474
// Assert
7575
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
7676
Assert.Equal(StatusCodes.Status201Created, producesResponseTypeMetadata.StatusCode);
77+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
7778
}
7879

7980
[Fact]

src/Http/Http.Results/test/NoContentResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
5353
// Assert
5454
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
5555
Assert.Equal(StatusCodes.Status204NoContent, producesResponseTypeMetadata.StatusCode);
56+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
5657
}
5758

5859
[Fact]

src/Http/Http.Results/test/NotFoundResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
5252
// Assert
5353
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
5454
Assert.Equal(StatusCodes.Status404NotFound, producesResponseTypeMetadata.StatusCode);
55+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
5556
}
5657

5758
[Fact]

src/Http/Http.Results/test/OkResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
5656
// Assert
5757
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
5858
Assert.Equal(StatusCodes.Status200OK, producesResponseTypeMetadata.StatusCode);
59+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
5960
}
6061

6162
[Fact]

src/Http/Http.Results/test/UnprocessableEntityResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
5656
// Assert
5757
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
5858
Assert.Equal(StatusCodes.Status422UnprocessableEntity, producesResponseTypeMetadata.StatusCode);
59+
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
5960
}
6061

6162
[Fact]

0 commit comments

Comments
 (0)